Maniphest T133054

Create browser test for add footer link in ext.popups.settings.js
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

https://github.com/wikimedia/mediawiki-extensions-Popups/blob/master/resources/ext.popups.settings.js#L191-L225

This should be tested with a browser test.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Popups	master	+112 -0	QA: add a browser test to cover "enable previews" feature

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		Jdlrobson	T111329 [GOAL] Page previews on mobileweb
		Resolved		phuedx	T133947 [EPIC] Reduce bloat of Page Previews RL module(s)
		Resolved		Jdlrobson	T144522 [EPIC] Hovercards technical debt and quality enhancements
		Resolved		Jdlrobson	T67103 [EPIC] Hovercards: Test Coverage
		Invalid		None	T133055 Split ext.popups.settings.js in units
		Resolved		phuedx	T133025 Unit test ext.popups.settings.js
		Resolved		phuedx	T133054 Create browser test for add footer link in ext.popups.settings.js
		Resolved		Jdlrobson	T133163 BetaFeatures test failure

Event Timeline

Jhernandez created this task.Apr 19 2016, 3:55 PM

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptApr 19 2016, 3:55 PM

Jhernandez created subtask T133055: Split ext.popups.settings.js in units.Apr 19 2016, 3:58 PM

MBinder_WMF added a project: Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters.Apr 19 2016, 8:38 PM

Jhernandez removed a subtask: T133055: Split ext.popups.settings.js in units.Apr 20 2016, 3:30 PM

Jhernandez added a parent task: T133055: Split ext.popups.settings.js in units.

Jhernandez added a parent task: T133025: Unit test ext.popups.settings.js.

Jhernandez removed a parent task: T133055: Split ext.popups.settings.js in units.Apr 20 2016, 3:32 PM

MBinder_WMF set the point value for this task to 2.Apr 20 2016, 3:34 PM

dr0ptp4kt moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 20 2016, 3:58 PM

Jhernandez moved this task from Needs Analysis to Ignore on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 21 2016, 4:59 PM

Danny_B moved this task from Unsorted to Test coverage on the Technical-Debt board.Apr 21 2016, 8:53 PM

Jhernandez moved this task from To Do to Done on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 25 2016, 4:17 PM

Jhernandez moved this task from Done to To Do on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.

bmansurov claimed this task.Apr 25 2016, 6:47 PM

bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.

Change 285281 had a related patch set uploaded (by Bmansurov):
QA: add a browser test to cover "enable previews" feature

https://gerrit.wikimedia.org/r/285281

gerritbot added a project: Patch-For-Review.Apr 25 2016, 8:55 PM

bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 25 2016, 8:56 PM

phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 26 2016, 9:17 AM

bmansurov moved this task from -1 (Needs More Work) to Doing on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 26 2016, 8:39 PM

bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 26 2016, 9:19 PM

I left some feedback on PS2.
I think this may be blocked on T133163

MBinder_WMF added a project: Readers-Web-Backlog.Apr 27 2016, 5:09 PM

MBinder_WMF moved this task from Incoming to 2015-16 Q4 on the Readers-Web-Backlog board.Apr 27 2016, 5:13 PM

bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 27 2016, 7:30 PM

Jdlrobson added a subtask: T133163: BetaFeatures test failure.Apr 27 2016, 8:41 PM

Jdlrobson moved this task from Code Review to Blocked Externally on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.

Jdlrobson moved this task from Blocked Externally to Code Review on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 28 2016, 12:18 AM

phuedx closed subtask T133163: BetaFeatures test failure as Resolved.Apr 28 2016, 4:47 AM

Change 285281 merged by jenkins-bot:
QA: add a browser test to cover "enable previews" feature

https://gerrit.wikimedia.org/r/285281

Signing this off as it's a technical task.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 28 2016, 8:58 AM

phuedx moved this task from Done to Ready for Signoff on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-05-03_(1.27.0-wmf.23)).Apr 28 2016, 9:00 AM