Page MenuHomePhabricator

[betalabs] flow-topic-resolved notifications should have a summary excerpt
Open, Needs TriagePublic

Description

According to V 2.0 Notifications -- Showing Updated Text and Links under NEW APPROVED BODY TEXT column, flow-topic-resolved notifications should include a Summary excerpt.

Presently, there will be two different notifications when a topic is Resolved with added or updated Summaries

  • "The summary was updated" notification which is somewhat misleading if a topic's summary was added simultaneously with Resolving the topic.
  • and "The topic was resolved" notification without a summary excerpt.

Event Timeline

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptApr 19 2016, 6:59 PM

if a topic's summary was added simultaneously with Resolving the topic

The problem is: Resolve and Summarize are independent actions that don't happen simultaneously even though the UI presents them one after the other. If you don't summarize, the topic is still resolved and the notification is already sent.

We had the same conversation a while ago about the 2 entries (resolve, summarize) in history, feeds, etc.

@Etonkovidova notes that:

Presently, there will be two different notifications when a topic is Resolved with added or updated Summaries

Stephane is right that two notifications should be sent, which is what happens: one is a flow-summary-edit notification and the other a flow-topic-resolved.

Elena showsv that the latter will be "without a summary excerpt." That's not what the spec says. HOWEVER, since, whenever the summary is provided and a topic resolved, both these notices will always be sent, then this behavior seems superior to what's in the spec (which would repeat the summary).

So I'm happy to change the spec to match this behavior, but wanted to make sure I'm not missing something. Would there, for instance, ever be a case where a summary would pre-exist the Resolution (so that there was a summary to report but it didn't change, so no summary message would go out)? Or any similar problem you guys can see?

Would there, for instance, ever be a case where a summary would pre-exist the Resolution (so that there was a summary to report but it didn't change, so no summary message would go out)?

The summary can be set or modified anytime before or after the resolution and a notification should be sent every time.

The flow-topic-resolved notification could include an excerpt of the current summary but since we invite the user to re-evaluate the summary right after resolution, there's a good chance that it was out of date.

Stephane has clarified,

a notification should be sent every time.

Thank you. I've updated the ticket description for T125654 to reflect that.

Etonkovidova updated the task description. (Show Details)Apr 21 2016, 9:20 PM

The problem is: Resolve and Summarize are independent actions that don't happen simultaneously even though the UI presents >them one after the other. If you don't summarize, the topic is still resolved and the notification is already sent.

I wonder why we do not have users' complaints about it. From a user point of view, clicking a menu item form the drop-down menu should not mean finalizing the action of 'Mark as resolved' for a topic.

Anyway, moving to 'Ready for Pickup' since the decision was made to provide summary excerpt (when a summary is present) for both

  • flow-topic-resolved notifications
  • and the subsequent flow-summary-edit notification if the summary was updated upon resolving the topic