Repositories that have ruby code have Gemfile. Example from mediawiki-selenium:
#ruby=ruby-2.1.1 #ruby-gemset=mediawiki_selenium source "https://rubygems.org" gemspec
The first two lines are for RVM. We do not officially recommend RVM any more. If a Gemfile starts with:
#ruby=ruby-(...) #ruby-gemset=(...)
the above two lines should be removed from the Gemfile.
The list of repositories where the change should be made:
https://github.com/search?q=org%3Awikimedia+%22ruby-gemset%22&type=Code
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Harjotsingh | T1331 Remove lines from Gemfile that are used by RVM | |||
| Declined | hashar | T75727 Move mediawiki_selenium Gemfile metadata to .ruby-version and .ruby-gemset | |||
| Declined | hashar | T75728 Move mediawiki_api Gemfile metadata to .ruby-version and .ruby-gemset |
I'm for leaving it to maintainers of each repo whether they want to use/recommend RVM, but leaving it out of new repos. For those that do want to recommend it, .ruby-version and .ruby-gemset files are a less intrusive alternative.
Since we're the maintainers of mediawiki_selenium and mediawiki_api, I vote to use the latter option. :)
-1 from me on introducing more files that just a few people use. If somebody needs those files, they are free to add them locally, and add them to .gitignore.
Updated list for extensions only:
$:foo\> cd /wikimedia/git/mediawiki-extensions/ $:foo\> grep -R -F 'gemset' . ./PoolCounter/Gemfile:#ruby-gemset=PoolCounter ./Wikibase/Gemfile:# ruby-gemset=Wikibase ./Wikidata/extensions/Wikibase/Gemfile:# ruby-gemset=Wikibase
So if I was a new contributor here (this task is tagged as good first task), what would I be supposed to do?
Clarification welcome in the task desc.
Try the github code search for ruby-gemset: https://github.com/search?q=org%3Awikimedia+%22ruby-gemset%22&type=Code
Hi I'm interested to work on this, Do I remove RVM on github and make a pull request or do I remove it and push to gerrit for review ?
Also you can usually reach both of us in the freenode IRC channel #wikimedia-releng though I am not connected this morning.
Change 342181 had a related patch set uploaded (by Harjotsingh):
[mediawiki/extensions/PoolCounter] Remove RVM lines from PoolCounter extension
Change 342184 had a related patch set uploaded (by Harjotsingh):
[mediawiki/extensions/Wikidata] Remove RVM lines from Wikidata extension
I don't know if it is the right way, but I added different commits for different extensions.
Wanted to ask if it is right before adding commits for other extensions.
Change 342181 merged by jenkins-bot:
[mediawiki/extensions/PoolCounter] Remove RVM lines from PoolCounter extension
Excellent @Harjotsingh . I got the change for PoolCounter merged. Looks like you can do the others.
The one for Wikidata should be done in Wikibase instead, I gave the whole explanation on the Gerrit change https://gerrit.wikimedia.org/r/342184
Change 342189 had a related patch set uploaded (by Harjotsingh):
[mediawiki/extensions/Wikibase] Remove RVM lines from Wikibase extension
@hashar Some file show in https://github.com/search?q=org%3Awikimedia+%22ruby-gemset%22&type=Code are gitignore files, what should I do with them as they are ignored by git ?
@Harjotsingh only remove the mentioned two lines for Gemfiles. Cleaning up .gitignore files can be another task.
Change 342189 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Remove RVM lines from Wikibase extension
Change 342216 had a related patch set uploaded (by Harjotsingh):
[mediawiki/ruby/api] Remove RVM lines from MediaWiki API from Ruby
Change 342216 merged by jenkins-bot:
[mediawiki/ruby/api] Remove RVM lines from MediaWiki API from Ruby
Change 342249 had a related patch set uploaded (by Harjotsingh):
[wikimedia/TransparencyReport] Remove RVM lines from Transparency Report
Looks like there is one more file left:
https://phabricator.wikimedia.org/diffusion/WTRR/browse/master/Gemfile
@zeljkofilipin The patch was reviewed but it's not getting verified.
https://gerrit.wikimedia.org/r/#/c/342249/
Change 342249 merged by Zfilipin:
[wikimedia/TransparencyReport] Remove RVM lines from Transparency Report
TransparencyReport report is configured in a strange way. I had to click "submit" and then the commit got merged.