Page MenuHomePhabricator
Create Task
Maniphest T133303

Verify table of contents fix in production
Closed, ResolvedPublic
Actions

Description

T126836 got merged last sprint and will ride the train from the 26th April.
Let's verify there are no problems in production.

Related Objects

Event Timeline

Jdlrobson created this task.Apr 21 2016, 4:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2016, 4:16 PM
Jdlrobson mentioned this in T126836: TOC causes flash of unstyled content when viewing MobileFrontend page on desktop.Apr 21 2016, 4:17 PM
Jdlrobson added a project: Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters.
Jdlrobson added a subscriber: phuedx.

@phuedx any reason you suggested verifying this in sprint 72 not 71?

MBinder_WMF added subscribers: dr0ptp4kt, MBinder_WMF.Apr 21 2016, 4:22 PM

@dr0ptp4kt Just want you to be aware of this ticket so you can weigh in on whether it should be in 71 or 72.

dr0ptp4kt added a subscriber: Catrope.Apr 21 2016, 4:33 PM

The description says it will ride the train 26th May. Is it actually 26th April 2016? It it's 26th April, please move this to Ready for Signoff for Sprint 71.

@Catrope originally reported the issue. @Catrope, would you be willing to confirm the fix works?

Jdlrobson updated the task description. (Show Details)Apr 21 2016, 4:35 PM
phuedx added a comment.Apr 21 2016, 4:45 PM
In T133303#2227669, @Jdlrobson wrote:

@phuedx any reason you suggested verifying this in sprint 72 not 71?

None.

dr0ptp4kt removed a project: Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one.Apr 21 2016, 6:02 PM
dr0ptp4kt moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.
Jdlrobson added a comment.Apr 26 2016, 11:34 PM

Verified on https://m.mediawiki.org/wiki/Reading/Web/Team and various other pages as anon and logged in user that everything is a-okay.
Leaving open in case anyone wants to run any tests of their own.

phuedx added a comment.Apr 27 2016, 10:11 AM

Let's wait until a320a9c has been deployed to group2 (Thursday, 28th April).

MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 5:09 PM
MBinder_WMF moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Apr 27 2016, 5:13 PM
dr0ptp4kt added a subscriber: • bmansurov.Apr 28 2016, 5:12 PM

@phuedx or @bmansurov would you please sign off?

• bmansurov closed this task as Resolved.Apr 28 2016, 7:21 PM
• bmansurov claimed this task.

Verified that it's working as expected on https://en.m.wikipedia.org/wiki/Book. If someone else wants to verify it, just visit the page and scroll down until you see the ToC and refresh the page, you'll see the space is reserved for the ToC to appear, and it does appear after a little while. On a smaller screen sizes the ToC doesn't appear at all, and that's the expected behavior.

• bmansurov removed • bmansurov as the assignee of this task.Apr 28 2016, 7:21 PM
• bmansurov moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL