Page MenuHomePhabricator

Language codes showing in Top read title for some languages. i.e. "als Wikipedia" instead of "English Wikipedia"
Closed, ResolvedPublic2 Estimated Story Points

Description

Screen Shot 2016-04-22 at 11.54.12 AM.png (1×675 px, 204 KB)

Event Timeline

Fjalapeno set the point value for this task to 2.Jun 20 2016, 3:36 PM

@JMinor having T121128 fixed would help enhance the fix for this issue. The current fix is having a generic title like "Top Sites on Wikipedia." Fixing T121128 with this would allow us to get the proper site name so we could say "Top Sites on Alemannisch Wikipedia". Is it worth upping the priority of T121128 and completing it alongside this fix?

Yes, okay by me, since thats something we'd hoped to do in 5.0.0. As long as the work for T12118 is in the "day or two" range, go ahead and pull it in (just add the 5.0.5 tag and move into right column on that board. If it seems more complex than a day or two, lets discuss at Tuesday's team planning.

To test:

  1. Uninstall the app
  2. Install the app
  3. During setup, set the primary language to als (Alemannische)
  4. Open the feed
  5. Verify that the top sites say. "Top Read on Wikipedia" and not "Top Read on als Wikipedia"

Tested on iOS 9.3.2 with iPhone, and latest Wikipedia 5.0.5 (900.1) app build. This is fixed as when set to Alemannische as primary language it says just "Top read".