Page MenuHomePhabricator

Restructure for easier implementation of QUnit tests
Closed, ResolvedPublic

Description

We can restructure the code a to make it easier to add QUnit tests for each collector + make it possible to do a simple test for the whole structure.

The problem today is that the collectors are depending on that start module has run. We can change that by using module.exports.

Event Timeline

Peter created this task.Apr 25 2016, 9:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2016, 9:19 AM

Change 285171 had a related patch set uploaded (by Phedenskog):
Use module.exports instead of global variables

https://gerrit.wikimedia.org/r/285171

Change 285171 abandoned by Phedenskog:
Use module.exports instead of global variables

Reason:
Ooops we want that in a branch.

https://gerrit.wikimedia.org/r/285171

Change 285177 had a related patch set uploaded (by Phedenskog):
Use module.exports instead of global variables

https://gerrit.wikimedia.org/r/285177

Change 285177 merged by jenkins-bot:
Use module.exports instead of global variables

https://gerrit.wikimedia.org/r/285177

Krinkle closed this task as Resolved.Aug 5 2016, 1:40 AM