Maniphest T133608

Cursor ends up inside template in Flow mention inspector (and possibly other inline templates)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Apr 25 2016, 10:18 PM

Project Tags

Referenced Files

	F3930185: pasted_file
	Apr 25 2016, 10:18 PM

Subscribers

Description

Where you can type, because the template is made up of two siblings.

pasted_file (91×50 px, 1 KB)

Worse still, I can end up inside the template again by cursoring right from the left.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Handle about groups correctly in getNodeAndOffset	VisualEditor/VisualEditor	master	+31 -4

Customize query in gerrit

Related Objects

Mentioned Here: T134468: ve.ce.FocusableNode throws an error on selecting an about group containing a top-level whitespace text node
T133610: Can't cursor onto inline alien at boundary of paragraph in Firefox

Event Timeline

Esanders created this task.Apr 25 2016, 10:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2016, 10:18 PM

Esanders updated the task description. (Show Details)Apr 25 2016, 10:19 PM

The second part of the bug (cursoring) only happens when the template is the only element in the paragraph. Test case for ve standalone:

<p><span about="#group1" rel="ve:Alien">Foo</span><a about="#group1" rel="ve:Alien" href="foo">Bar</a></p>

Esanders added a project: VisualEditor-ContentEditable.Apr 25 2016, 10:24 PM

See also T133610

Esanders renamed this task from Cursor ends up inside template in Flow mention inspector to Cursor ends up inside template in Flow mention inspector (and possibly other inline templates).Apr 25 2016, 10:29 PM

Jdforrester-WMF triaged this task as High priority.Apr 26 2016, 7:09 PM

Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.

Change 287048 had a related patch set uploaded (by Divec):
Handle about groups correctly in getNodeAndOffset

https://gerrit.wikimedia.org/r/287048

gerritbot added a project: Patch-For-Review.May 5 2016, 5:37 AM

See also T134468

Change 287048 merged by jenkins-bot:
Handle about groups correctly in getNodeAndOffset

https://gerrit.wikimedia.org/r/287048

Jdforrester-WMF closed this task as Resolved.May 6 2016, 3:08 PM

Jdforrester-WMF assigned this task to dchan.

Jdforrester-WMF edited projects, added: MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)); removed: Patch-For-Review.

Jdforrester-WMF set the point value for this task to 8.