Page MenuHomePhabricator
Create Task
Maniphest T133633

Coding conventions
Closed, InvalidPublic
Actions

Description

Use phpcs/phpcbf to lint PHP code.
https://github.com/wikimedia/mediawiki-tools-codesniffer

  • composer.json
  • phpcs.xml
  • Run phpcbf (composer fix).
  • Fix problems cannot be autofixed.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Follow coding conventions.小璋丸mediawiki/extensions/QuickGVmaster+429 -336
Indent with spaces and update version string.小璋丸mediawiki/extensions/QuickGVmaster+167 -163
Customize query in gerrit

Revisions and Commits

rEQGV extension-QuickGV
rEQGVbea7c9364b03 refs T133633 Add space characters and syntax highlight.
rEQGVfb4e4515e690 refs T133633 Follow coding conventions.
rEQGV208eeb943a75 refs T133633, Follow coding conventions.
rEQGV4dbb3b8da4d4 refs T133633, Follow coding conventions (Line: 1~210)
rEQGV872d6310a224 refs T133633, Fix second key, which confict with global one.
rEQGVb57d003a4a7e refs T133633, Follow coding conventions (Line: 201~345)

Related Objects

Event Timeline

raymondwu created this task.Apr 26 2016, 3:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2016, 3:23 AM
gerritbot subscribed.Apr 26 2016, 3:24 AM

Change 285143 had a related patch set uploaded (by 小璋丸):
refs #T133633 Follow coding conventions.

https://gerrit.wikimedia.org/r/285143

gerritbot added a project: Patch-For-Review.Apr 26 2016, 3:24 AM
gerritbot added a comment.Apr 26 2016, 3:27 AM

Change 285151 had a related patch set uploaded (by 小璋丸):
refs T133633, Fix second key, which confict with global one.

https://gerrit.wikimedia.org/r/285151

gerritbot added a comment.Apr 26 2016, 3:27 AM

Change 285152 had a related patch set uploaded (by 小璋丸):
refs T133633, Follow coding conventions (Line: 1~210)

https://gerrit.wikimedia.org/r/285152

gerritbot added a comment.Apr 26 2016, 3:27 AM

Change 285153 had a related patch set uploaded (by 小璋丸):
refs T133633, Follow coding conventions (Line: 201~345)

https://gerrit.wikimedia.org/r/285153

Aklapper added a comment.Apr 26 2016, 11:03 AM

@raymondwu: Do you know where the bug tracker for https://www.mediawiki.org/wiki/Extension:QuickGV is located? There is no information on the wiki page...
If you are its maintainer and want a project in Phabricator, please see https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#New_projects - thanks!

raymondwu added a comment.Apr 26 2016, 11:09 AM

I'm the maintainer. But I don't have privilege to create project.

Aklapper added a project: MediaWiki-extensions-Other.Apr 26 2016, 3:40 PM

Please see https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#New_projects - thanks!

raymondwu added a comment.Apr 26 2016, 4:25 PM

Thanks I'll try it.

raymondwu added a commit: rEQGVb57d003a4a7e: refs T133633, Follow coding conventions (Line: 201~345).Apr 28 2016, 12:50 AM
raymondwu added a commit: rEQGV4dbb3b8da4d4: refs T133633, Follow coding conventions (Line: 1~210).
raymondwu added a commit: rEQGV872d6310a224: refs T133633, Fix second key, which confict with global one..
raymondwu added a commit: rEQGV208eeb943a75: refs T133633, Follow coding conventions..
raymondwu added a commit: rEQGVfb4e4515e690: refs T133633 Follow coding conventions..
raymondwu edited projects, added: MediaWiki-extensions-QuickGV; removed: MediaWiki-extensions-Other.May 4 2016, 2:27 AM
raymondwu updated the task description. (Show Details)May 4 2016, 10:58 AM
gerritbot added a comment.May 5 2016, 6:21 AM

Change 287056 had a related patch set uploaded (by 小璋丸):
refs #T133633 Add space characters and syntax highlight.

https://gerrit.wikimedia.org/r/287056

raymondwu added a commit: rEQGVbea7c9364b03: refs T133633 Add space characters and syntax highlight..May 5 2016, 6:23 AM
raymondwu mentioned this in T134365: Localisation improvement: Convert language file as JSON format.May 11 2016, 6:34 AM
raymondwu renamed this task from QuickGV coding conventions fix to Coding conventions, syntax highlighting, and version string..May 26 2016, 6:47 AM
raymondwu updated the task description. (Show Details)
raymondwu mentioned this in rEQGV127c17c9aa85: Indent with spaces and update version string..May 26 2016, 7:26 AM
raymondwu mentioned this in rEQGVae50bb8bcfd9: Indent with spaces and improve comments..
raymondwu mentioned this in rEQGV6bf7a6d11c86: Indent with spaces..
raymondwu mentioned this in rEQGVea75d7fc2511: Indent with spaces and highlight dot source..
raymondwu mentioned this in rEQGV17be862bf49b: Indent with spaces and highlight dot source..
raymondwu mentioned this in rEQGVe89baf5f7805: Indent with spaces..
raymondwu mentioned this in rEQGVd9806a4bd735: Indent with spaces and highlight dot source..
raymondwu mentioned this in rEQGV76033dc98672: Syntax highlighting..
raymondwu mentioned this in rEQGVa280da114b82: Indent with spaces and improve comments..
raymondwu mentioned this in rEQGV15d15f5e220c: Indent with spaces and improve comments..
raymondwu mentioned this in rEQGV386ced9a37e6: Replace language key "seconds" with "quickgv-sec"..
raymondwu mentioned this in rEQGVd5b821405cdc: Indent with spaces and improve comments..
raymondwu mentioned this in rEQGV3fb731cc0133: Indent with spaces and improve comments..
raymondwu mentioned this in rEQGVc4331d96d839: Indent with spaces and improve comments..
raymondwu mentioned this in rEQGV4a5d0e439a43: * Indent with spaces. ** QuickGV.template.php * Improve comments..
raymondwu mentioned this in rEQGVbb81b2511f2c: * Indent with spaces and improve comments. ** QuickGV.php ** QuickGV.i18n.php….
gerritbot added a comment.May 26 2016, 12:44 PM

Change 285143 had a related patch set uploaded (by Aklapper):
Indent with spaces and update version string.

https://gerrit.wikimedia.org/r/285143

Aklapper mentioned this in rEQGV429b6d952f47: Indent with spaces and update version string..May 26 2016, 12:46 PM
gerritbot added a comment.May 26 2016, 4:44 PM

Change 285143 merged by Raimond Spekking:
Indent with spaces and update version string.

https://gerrit.wikimedia.org/r/285143

raymondwu renamed this task from Coding conventions, syntax highlighting, and version string. to Coding conventions.Aug 12 2016, 3:59 AM
raymondwu updated the task description. (Show Details)
raymondwu updated the task description. (Show Details)Dec 27 2016, 9:29 AM
gerritbot added a comment.Jan 26 2017, 6:51 PM

Change 334405 had a related patch set uploaded (by 小璋丸):
Follow coding conventions.

https://gerrit.wikimedia.org/r/334405

raymondwu updated the task description. (Show Details)Jan 26 2017, 6:54 PM
raymondwu mentioned this in rEQGVa5be782c3d09: Follow coding conventions..Jan 26 2017, 7:09 PM
Liuxinyu970226 mentioned this in rEQGV20b41fb6ae03: Follow coding conventions..Jan 27 2017, 1:16 AM
Liuxinyu970226 mentioned this in rEQGVbee0b863755b: Follow coding conventions..Mar 11 2017, 4:03 PM
• Razyfouad mentioned this in rEQGVc066f78817cf: Follow coding conventions..Apr 6 2019, 2:04 AM
Aklapper added a project: Patch-Needs-Improvement.Jun 29 2020, 8:46 AM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptJun 29 2020, 8:46 AM
Aklapper edited projects, added: Patch-Needs-Improvement; removed: Patch-For-Review.Jun 29 2020, 8:47 AM
Aklapper removed raymondwu as the assignee of this task.Dec 19 2020, 11:27 AM

Removing task assignee due to inactivity, as this open task has been assigned to the same person for more than two years (see the emails sent to the task assignee on Oct27 and Nov23). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Pppery closed this task as Invalid.Mar 7 2026, 4:36 AM
Pppery subscribed.

Closing per T413348: Archive the QuickGV extension from Gerrit

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits