This ticket is to refactor any code that is needed to get the new descriptive text into production for the sister project links.
The ticket for the test is here: https://phabricator.wikimedia.org/T131238
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| T133734 refactoring new footer for production Replacing old footer with new one. | wikimedia/portals | master | +160 -246 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • debt | T133732 Release to production (Egg): adding descriptive text to sister project links | |||
| Resolved | Jdrewniak | T133734 Refactor code for (Egg): adding descriptive text to sister project links |
Event Timeline
Comment Actions
Change 289158 had a related patch set uploaded (by Jdrewniak):
T133734 refactoring new footer for production Replacing old footer with new one.
Comment Actions
vs
I tried to merge the patch, but it needs a rebase.
Anyway, I noticed the outline is not fixed, as it has become inconsistent with the rest of the page now.
See:
vs
Comment Actions
hey @JGirault Alright, well I guess changing the focus state to underlines was the 'easy' way out... The project links were at a fixed height which is why the outline looked weird, but I added an extra wrapper around them so the anchor tag matches the height of the content now :)
Comment Actions
Change 289158 merged by jenkins-bot:
T133734 refactoring new footer for production Replacing old footer with new one.