This ticket is to refactor any code that is needed to get the new descriptive text into production for the sister project links.
The ticket for the test is here: https://phabricator.wikimedia.org/T131238
debt | |
Apr 26 2016, 7:34 PM |
F4027417: Screen Shot 2016-05-18 at 2.23.53 PM.png | |
May 18 2016, 12:27 PM |
F4025569: Screen Shot 2016-05-17 at 5.52.45 PM.png | |
May 18 2016, 12:57 AM |
F4025564: Screen Shot 2016-05-17 at 5.53.22 PM.png | |
May 18 2016, 12:57 AM |
F4025567: Screen Shot 2016-05-17 at 5.53.11 PM.png | |
May 18 2016, 12:57 AM |
F3962790: outline.png | |
May 16 2016, 3:38 PM |
F3962794: Screen Shot 2016-05-03 at 8.55.38 AM.png | |
May 16 2016, 3:38 PM |
This ticket is to refactor any code that is needed to get the new descriptive text into production for the sister project links.
The ticket for the test is here: https://phabricator.wikimedia.org/T131238
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
T133734 refactoring new footer for production Replacing old footer with new one. | wikimedia/portals | master | +160 -246 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | debt | T133732 Release to production (Egg): adding descriptive text to sister project links | |||
Resolved | Jdrewniak | T133734 Refactor code for (Egg): adding descriptive text to sister project links |
We'll use these images from https://phabricator.wikimedia.org/T132518 to help refactor the code.
Change 289158 had a related patch set uploaded (by Jdrewniak):
T133734 refactoring new footer for production Replacing old footer with new one.
I tried to merge the patch, but it needs a rebase.
Anyway, I noticed the outline is not fixed, as it has become inconsistent with the rest of the page now.
See:
hey @JGirault Alright, well I guess changing the focus state to underlines was the 'easy' way out... The project links were at a fixed height which is why the outline looked weird, but I added an extra wrapper around them so the anchor tag matches the height of the content now :)
Change 289158 merged by jenkins-bot:
T133734 refactoring new footer for production Replacing old footer with new one.