Page MenuHomePhabricator

Refactor code for (Egg): adding descriptive text to sister project links
Closed, ResolvedPublic

Description

This ticket is to refactor any code that is needed to get the new descriptive text into production for the sister project links.

The ticket for the test is here: https://phabricator.wikimedia.org/T131238

Event Timeline

debt moved this task from What's Next to In Progress on the Discovery-Portal-Sprint board.

We'll use these images from https://phabricator.wikimedia.org/T132518 to help refactor the code.


Change 289158 had a related patch set uploaded (by Jdrewniak):
T133734 refactoring new footer for production Replacing old footer with new one.

https://gerrit.wikimedia.org/r/289158

I tried to merge the patch, but it needs a rebase.
Anyway, I noticed the outline is not fixed, as it has become inconsistent with the rest of the page now.

See:


vs

hey @JGirault Alright, well I guess changing the focus state to underlines was the 'easy' way out... The project links were at a fixed height which is why the outline looked weird, but I added an extra wrapper around them so the anchor tag matches the height of the content now :)

Change 289158 merged by jenkins-bot:
T133734 refactoring new footer for production Replacing old footer with new one.

https://gerrit.wikimedia.org/r/289158

This was pushed into production on May 18, 2016