Page MenuHomePhabricator

WikiPage::something error encountered while adding two users to Tools project at the same time
Closed, InvalidPublic

Description

When adding two users simultaneously via https://wikitech.wikimedia.org/w/index.php?title=Special:NovaProject&action=addmember&projectid=tools&member=Sfic, I encountered an error message which I unfortunately discarded because I thought it was transient. IIRC it was WikiPage::lockAndGetPage and saying that the database transaction did not succeed.

What motivated me to file this bug though, is that the user Sfic was added to the Tools project in the OpenStack list at https://wikitech.wikimedia.org/wiki/Special:NovaProject, but not in the generated wiki list at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools. I assume this will be corrected when the next user is added.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

if you can reproduce error and tell us what it is I may take a look

Sfic was not added to the list at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools when subsequent users were added. Maybe some overzealous caching?

Does this happen every time you add multiple people? I successfully submitted the form for deployment prep with Tim Landscheidt,Merlijn van Deen
(Although the success messages looked a bit weird, https://gerrit.wikimedia.org/r/#/c/286310/ to fix that)

I added the two users in two separate browser tabs, with only one username in the input field. (I wasn't aware that it accepted multiple users, and I would need to rewrite my tl-wikitech-work-on-requests function to take advantage of that :-)).

Regarding Sfic now appearing in the list at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools: Immediately before I submitted my comment here this morning, I went to https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools, clicked on "[Expand]" for "Members" and searched for "Sfic" to no avail. I did not look at or search the page source.

So maybe the error lies with Semantic MediaWiki processing the page source to database data to display data? IIRC there was a similar problem with the Bastion project where updating the list of members triggered a time-out and you (?) solved that by disabling the members list for Bastion. For Toolforge, such a solution would be suboptimal.

Honestly I'm tempted to decline this in favour of migrating to Horizon in T91988 instead (if I understand the scope of that task correctly)

scfc triaged this task as Lowest priority.May 4 2016, 12:39 AM

T91988 would make this report probably obsolete, yes. I personally don't close bug reports for active infrastructure until it has been shut down, so I'll set the priority for this task instead.