Echo phpunit tests fail together with other extensions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JanZerebecki
	Apr 27 2016, 12:58 PM

Description

Originally from https://phabricator.wikimedia.org/T110604#2241193 .
With https://gerrit.wikimedia.org/r/#/c/285423/ retesting https://gerrit.wikimedia.org/r/#/c/285155/ gives an error
https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/10468/console

19:30:51 1) EchoUserLocatorTest::testLocateArticleCreator with data set #0 ('Something', Closure$EchoUserLocatorTest::locateArticleCreatorProvider;1324735286 Object (...))
19:30:51 Something
19:30:51 Failed asserting that two arrays are equal.
19:30:51 --- Expected
19:30:51 +++ Actual
19:30:51 @@ @@
19:30:51  Array (
19:30:51 -    0 => 2
19:30:51  )
19:30:51 
19:30:51 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Echo/tests/phpunit/UserLocatorTest.php:131
19:30:51 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:156

Removing Echo only from Wikidata https://gerrit.wikimedia.org/r/#/c/285453/ until it is fixed.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Revert "add Wikidata dependency on ContentTranslation"	integration/config	master	+1 -1
	Remove generic dependency for Wikibase on Echo.	integration/config	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	thiemowmde	T142940 Create client functionality for getting human readable wikitext from Wikibase statements
Declined	None	T99897 {{#property}} parser function should output EntityIdValues as local wiki links, once we have article placeholders
Resolved	Lydia_Pintscher	T135624 Second round of the ArticlePlaceholder rollout (tracking)
Resolved	hoo	T130997 [Task] Configure ArticlePlaceholder for nnwiki
Invalid	Lydia_Pintscher	T99896 Use Lua for custom rendering of entity data on Special:ShowEntity
Resolved	Lucie	T99895 [Epic] Article placeholder based on data from Wikidata
Resolved	Lucie	T109445 [Story] Display the Article Placeholder
Resolved	Lucie	T109447 [Story] default display for article placeholder
Resolved	Lucie	T109578 [Story] extended display for article placeholder
Open	None	T125434 Research on right to left languages layout in ArticlePlaceholder
Resolved	Lucie	T109451 [Story] Creation of article from Article Placeholder
Resolved	Lucie	T109453 [Story] Create and translate article
Resolved	Addshore	T123087 [Task] Track use of Create Article and Translate Article buttons
Resolved	Lucie	T117965 Review and deploy of the ArticlePlaceholder extension
Resolved	Lucie	T117683 [Tracking] Finish minimal loveable product as beta feature
Resolved	• Jonas	T124036 [Task] Add button to translate article
Resolved	Aklapper	T133774 Echo phpunit tests fail together with other extensions

Event Timeline

JanZerebecki created this task.Apr 27 2016, 12:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2016, 12:58 PM

JanZerebecki mentioned this in T110604: [Story] Notification: Add notification when page is being connected to Wikidata.Apr 27 2016, 1:00 PM

Change 285638 had a related patch set uploaded (by JanZerebecki):
Remove generic dependency for Wikibase on Echo.

https://gerrit.wikimedia.org/r/285638

Change 285638 merged by jenkins-bot:
Remove generic dependency for Wikibase on Echo.

https://gerrit.wikimedia.org/r/285638

JanZerebecki updated the task description. (Show Details)Apr 27 2016, 1:14 PM

• Mattflaschen-WMF added a project: Collaboration-Team-Triage.Apr 27 2016, 8:01 PM

aude mentioned this in T132645: [Bug] fatal error: Argument 1 passed to CachingEntityRevisionLookup::getEntityRevision() must be an instance of EntityId, null given.Apr 29 2016, 1:20 AM

Change 286174 had a related patch set uploaded (by JanZerebecki):
Revert "add Wikidata dependency on ContentTranslation"

https://gerrit.wikimedia.org/r/286174

JanZerebecki added a parent task: T124036: [Task] Add button to translate article.Apr 29 2016, 4:24 PM

JanZerebecki mentioned this in T124036: [Task] Add button to translate article.

JanZerebecki added a parent task: T110604: [Story] Notification: Add notification when page is being connected to Wikidata.

matej_suchanek subscribed.Apr 29 2016, 4:29 PM

Change 286174 merged by jenkins-bot:
Revert "add Wikidata dependency on ContentTranslation"

https://gerrit.wikimedia.org/r/286174

matej_suchanek awarded a token.Apr 29 2016, 7:54 PM

Lucie moved this task from Incoming to Doing on the ArticlePlaceholder board.May 18 2016, 12:51 PM

Lucie moved this task from Doing to To Do Next on the ArticlePlaceholder board.

Lucie removed a project: Patch-For-Review.

matej_suchanek removed a parent task: T110604: [Story] Notification: Add notification when page is being connected to Wikidata.Jun 29 2016, 8:39 PM

matej_suchanek rescinded a token.

Lucie added a project: TestMe.Oct 28 2016, 10:25 AM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 28 2016, 10:25 AM

Is this fixed now?

All patches merged; no reply to last comment.
Assuming this is fixed. If not, please reopen.

matej_suchanek unsubscribed.Mar 1 2017, 2:36 PM

hoo moved this task from To Do Next to Done on the ArticlePlaceholder board.Apr 3 2017, 3:34 PM

Echo phpunit tests fail together with other extensionsClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Echo phpunit tests fail together with other extensions
Closed, ResolvedPublic
Actions

Related Objects
Search...