Page MenuHomePhabricator
Create Task
Maniphest T133787

Ctrl or shift + click on "full screen" should open map in a new tab
Closed, ResolvedPublic
Actions

Description

Some advanced users have asked to be able to view full screen map in a separate tab. I think full screen in the same tab is more intuitive for novice users, but ctrl+click or shift+click should open the full screen map in a new tab. Also, there should be a tooltip explaining about shift being "pop-out" (similar to gmail's compose email screen)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Kartographermaster+24 -16Make full screen control a real link so users can open it in a new tab/window.
Customize query in gerrit

Related Objects

Event Timeline

Yurik created this task.Apr 27 2016, 4:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2016, 4:21 PM
Yurik moved this task from Unsorted to UI tasks on the Maps (Kartographer) board.Apr 27 2016, 4:22 PM
Yurik added a project: Maps.May 17 2016, 8:34 PM
Restricted Application added a project: Discovery. · View Herald TranscriptMay 17 2016, 8:34 PM
Yurik moved this task from All map-related tasks to Kartographer on the Maps board.May 17 2016, 8:36 PM
Yurik mentioned this in T137910: Ctrl/Shift+click on <maplink> should open full screen in a separate tab/window.Jun 15 2016, 6:28 PM
JGirault added a project: Maps-Sprint.Jun 17 2016, 5:36 PM
JGirault moved this task from Backlog to In progress on the Maps-Sprint board.
JGirault claimed this task.Jun 17 2016, 5:38 PM
gerritbot added a subscriber: gerritbot.Jun 17 2016, 7:19 PM

Change 294943 had a related patch set uploaded (by JGirault):
Make full screen control a real link so users can open it in a new tab/window.

https://gerrit.wikimedia.org/r/294943

gerritbot added a project: Patch-For-Review.Jun 17 2016, 7:19 PM
JGirault moved this task from In progress to Needs review on the Maps-Sprint board.Jun 17 2016, 7:20 PM
gerritbot added a comment.Jun 21 2016, 11:30 AM

Change 294943 merged by jenkins-bot:
Make full screen control a real link so users can open it in a new tab/window.

https://gerrit.wikimedia.org/r/294943

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-21_(1.28.0-wmf.7)).Jun 21 2016, 12:00 PM
JGirault closed this task as Resolved.Jun 21 2016, 11:12 PM
debt mentioned this in T150970: Maps should open up in a pop-up modal (not full screen).Nov 17 2016, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL