Page MenuHomePhabricator

Fatal error: Call to undefined method ApiEchoNotifications::getNotifications() in NotificationsTest.php on line 27
Closed, InvalidPublic

Description

when running phpunit tests for echo (pointing phpunit to the test directory)

Fatal error: Call to undefined method ApiEchoNotifications::getNotifications() in /var/www/wiki/w/extensions/Echo/tests/NotificationsTest.php on line 27

These tests are not run by jenkins and not sure these tests ever worked? (If I check out 3e94bfac8b3e6a86a108c1588dc08d5882d856fe, I don't find ApiEchoNotifications::getNotifications)

We should either make the tests work (and have jenkins run them) or remove it.

Event Timeline

aude created this task.Apr 27 2016, 6:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2016, 6:51 PM

This test file was created by @Legoktm in 2013 (3e94bfac8b3e6a86a108c1588dc08d5882d856fe) and hasn't been modified since apart from mass-update commits. I think the reason Jenkins doesn't run it is because it's not in the phpunit/ directory.

Untagging, does not affect Jenkins passing on WMF-deployed repos.

Krinkle removed a subscriber: Krinkle.Apr 14 2018, 12:38 AM
SBisson closed this task as Invalid.Apr 19 2019, 6:28 PM
SBisson added a subscriber: SBisson.

This is invalid now that Echo/tests/NotificationsTest.php doesn't exist anymore.