Page MenuHomePhabricator
Create Task
Maniphest T133817

Notifications hangs at nowiki
Closed, ResolvedPublic
Actions

Description

Response header from the last request before the notifications start hanging and responded with an error

response.txt3 KBDownload

The actual error

TypeError: notifData.timestamp is undefined
https://no.wikipedia.org/w/extensions/Echo/modules/viewmodel/mw.echo.dm.NotificationsModel.js?54d1a
Line 491

Screendump

Screendum echo 2016-04-27-hangs.png (331×566 px, 32 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Echowmf/1.27.0-wmf.21+3 -0Follow-up 1608a5e6fc: add hasOwnProperty check
mediawiki/extensions/Echowmf/1.27.0-wmf.22+3 -0Follow-up 1608a5e6fc: add hasOwnProperty check
mediawiki/extensions/Echomaster+3 -0Follow-up 1608a5e6fc: add hasOwnProperty check
Customize query in gerrit

Related Objects

Event Timeline

jeblad created this task.Apr 27 2016, 9:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2016, 9:36 PM
jeblad updated the task description. (Show Details)Apr 27 2016, 9:43 PM
Catrope added a subscriber: Catrope.Apr 27 2016, 9:48 PM

This is because there's code extending Array.prototype. I'll add a hasOwnProperty check shortly.

gerritbot added a subscriber: gerritbot.Apr 27 2016, 9:59 PM

Change 285762 had a related patch set uploaded (by Catrope):
Follow-up 1608a5e6fc: add hasOwnProperty check

https://gerrit.wikimedia.org/r/285762

gerritbot added a project: Patch-For-Review.Apr 27 2016, 9:59 PM
jeblad added a comment.Apr 27 2016, 10:10 PM

My extension, its used in two gadgets.

gerritbot added a comment.Apr 28 2016, 12:53 AM

Change 285762 merged by jenkins-bot:
Follow-up 1608a5e6fc: add hasOwnProperty check

https://gerrit.wikimedia.org/r/285762

gerritbot added a comment.Apr 28 2016, 1:00 AM

Change 285892 had a related patch set uploaded (by Catrope):
Follow-up 1608a5e6fc: add hasOwnProperty check

https://gerrit.wikimedia.org/r/285892

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-05-03_(1.27.0-wmf.23)).Apr 28 2016, 1:00 AM
gerritbot added a comment.Apr 28 2016, 1:01 AM

Change 285893 had a related patch set uploaded (by Catrope):
Follow-up 1608a5e6fc: add hasOwnProperty check

https://gerrit.wikimedia.org/r/285893

gerritbot added a comment.Apr 28 2016, 1:08 AM

Change 285892 merged by jenkins-bot:
Follow-up 1608a5e6fc: add hasOwnProperty check

https://gerrit.wikimedia.org/r/285892

gerritbot added a comment.Apr 28 2016, 1:11 AM

Change 285893 merged by jenkins-bot:
Follow-up 1608a5e6fc: add hasOwnProperty check

https://gerrit.wikimedia.org/r/285893

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)).Apr 28 2016, 2:00 AM
Stashbot added a subscriber: Stashbot.Apr 28 2016, 3:03 AM

Mentioned in SAL [2016-04-28T03:03:28Z] <catrope@tin> Synchronized php-1.27.0-wmf.21/extensions/Echo: Fix T133817 (originally scheduled for SWAT) (duration: 00m 39s)

Stashbot added a comment.Apr 28 2016, 3:04 AM

Mentioned in SAL [2016-04-28T03:04:02Z] <catrope@tin> Synchronized php-1.27.0-wmf.22/extensions/Echo: Fix T133817 (originally scheduled for SWAT) (duration: 00m 34s)

Catrope added a comment.Apr 28 2016, 3:07 AM

@jeblad This should be fixed now, can you verify?

jeblad added a comment.Apr 28 2016, 9:30 PM

Yes, it seems to be fixed

jeblad closed this task as Resolved.Apr 28 2016, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL