Page MenuHomePhabricator
Create Task
Maniphest T134082

Add test to check if right resources are loaded
Closed, ResolvedPublic
Actions

Description

Kartographer php unit tests should check if the right modules get loaded. This way we can check that only needed resources get sent to the browser. Eg maplink should not load mapbox resource, etc.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Kartographermaster+43 -5Added resource loading test
Customize query in gerrit

Related Objects
Search...

Event Timeline

Yurik created this task.Apr 30 2016, 11:19 PM
Restricted Application added a project: Discovery. · View Herald TranscriptApr 30 2016, 11:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Yurik moved this task from Unsorted to General on the Maps (Kartographer) board.May 1 2016, 12:41 AM
Yurik moved this task from All map-related tasks to Kartographer on the Maps board.May 12 2016, 10:59 PM
MaxSem added a project: Maps-Sprint.May 27 2016, 6:40 PM
Yurik moved this task from Backlog to To-do on the Maps-Sprint board.May 27 2016, 10:13 PM
Yurik claimed this task.May 28 2016, 3:32 PM
gerritbot added a subscriber: gerritbot.May 28 2016, 3:34 PM

Change 291517 had a related patch set uploaded (by Yurik):
Added resource loading test

https://gerrit.wikimedia.org/r/291517

gerritbot added a project: Patch-For-Review.May 28 2016, 3:34 PM
Yurik moved this task from To-do to Needs review on the Maps-Sprint board.May 28 2016, 3:35 PM
Yurik added a parent task: T134079: <maplink> without <mapframe> still loads leaflet libs on page load.May 28 2016, 6:25 PM
gerritbot added a comment.Jun 1 2016, 5:40 PM

Change 291517 merged by jenkins-bot:
Added resource loading test

https://gerrit.wikimedia.org/r/291517

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Jun 1 2016, 6:00 PM
MaxSem closed this task as Resolved.Jun 1 2016, 10:20 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL