Page MenuHomePhabricator
Create Task
Maniphest T134124

Evaluator freeze/timeout on unclosed comment
Closed, ResolvedPublic
Actions

Description

Filter evaluator seems to freeze/timeout on filter snippet, inadvertently containing an indented unclosed comment

It can be reproduced by applying filter code as simple as the following (there has to be some whitespace preceding /*)

/* unclosed comment...

on some log entry, e.g.:
https://sk.wikipedia.org/wiki/%C5%A0peci%C3%A1lne:FilterZneu%C5%BEit%C3%AD/examine/log/15874

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Properly detect unclosed commentsmediawiki/extensions/AbuseFiltermaster+7 -1
Customize query in gerrit

Related Objects

Event Timeline

Teslaton created this task.May 1 2016, 6:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2016, 6:18 PM
Daimona triaged this task as Medium priority.Mar 25 2018, 2:22 PM
Daimona moved this task from Backlog to Internal bugs on the AbuseFilter board.
gerritbot subscribed.Apr 10 2018, 5:27 PM

Change 425321 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Properly detect unclosed comments

https://gerrit.wikimedia.org/r/425321

gerritbot added a project: Patch-For-Review.Apr 10 2018, 5:27 PM
Daimona claimed this task.Apr 10 2018, 5:28 PM
Daimona subscribed.

A bit of explanation on gerrit. Basically we have a while loop which never ends while tokenizing the rules, thus causing the timeout.

gerritbot added a comment.Apr 11 2018, 12:02 AM

Change 425321 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Properly detect unclosed comments

https://gerrit.wikimedia.org/r/425321

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 11 2018, 1:00 AM
Huji closed this task as Resolved.Apr 11 2018, 2:15 AM
Huji removed a project: Patch-For-Review.
Daimona mentioned this in T198531: Parser: wrong exception thrown for arrays.Jun 30 2018, 3:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits