In c765e76a72c3 I added the PHP unit test structure (via Composer entry-point) and in c99668d56189 I added it to the CI config with the composer-test55 template.
Now the tests are failing because composer-test55 includes composer-hhvm-trusty, which fails on the preg_replace construct.
I’m not entirely sure what’s happening here. I do understand that “this feature was DEPRECATED in PHP 5.5.0, and REMOVED as of PHP 7.0.0.”. If I understand correctly, the HHVM job runs PHP 5.6.99. Certainly the job should raise a deprecation warning without failing? But why a construct fine in the composer-php55 builder is not in composer-hhvm?
I’m not sure what do here either. I could refactor the code to not use the deprecated feature ; but on the other hand I don’t think we have any interest in supporting any PHP version besides whatever is on ToolLabs (5.5.9 as of now I believe) ; and certainly not HHVM.
Alternatively I change the CI config by only executing composer-php55 (and composer-validate etc) but I won’t be able to use the template so will have some duplication.
Thoughts @hashar and @Lokal_Profil ?