Page MenuHomePhabricator

AstroPay: internal exception caused by currency
Closed, ResolvedPublic

Description

Don't know what this is yet, but I found it in payments.error:

May  2 23:03:22 payments1003 astropay_gateway:  Exception in GatewayPage constructor with adapter class AstropayAdapter: No supported currencies for GB 
 #0 /X/payments/extensions/DonationInterface/gateway_common/DataValidator.php(318): AstropayAdapter->getCurrencies(Array)
 #1 /X/payments/extensions/DonationInterface/gateway_common/DonationData.php(977): DataValidator::validate(Object(AstropayAdapter), Array, Array)
 #2 /X/payments/extensions/DonationInterface/gateway_common/DonationData.php(344): DonationData->getValidationErrors()
 #3 /X/payments/extensions/DonationInterface/gateway_common/DonationData.php(147): DonationData->normalize()
 #4 /X/payments/extensions/DonationInterface/gateway_common/DonationData.php(115): DonationData->populateData(NULL)
 #5 /X/payments/extensions/DonationInterface/gateway_common/gateway.adapter.php(268): DonationData->__construct(Object(AstropayAdapter), NULL)
 #6 /X/payments/extensions/DonationInterface/gateway_common/GatewayPage.php(65): GatewayAdapter->__construct()
 #7 /X/payments/includes/specialpage/SpecialPageFactory.php(410): GatewayPage->__construct()
 #8 /X/payments/includes/specialpage/SpecialPageFactory.php(538): SpecialPageFactory::getPage('AstropayGateway')
 #9 /X/payments/includes/MediaWiki.php(267): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
 #10 X//payments/includes/MediaWiki.php(566): MediaWiki->performRequest()
 #11 X//payments/includes/MediaWiki.php(414): MediaWiki->main()
 #12 X//payments/index.php(41): MediaWiki->run()
 #13 {main}

Event Timeline

Change 619785 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Stop currency exception in AstroPay constructor

https://gerrit.wikimedia.org/r/619785

Change 619785 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Stop currency exception in AstroPay constructor

https://gerrit.wikimedia.org/r/619785

Looks like we're getting a few of these a day. I counted 20 for today.

jgleeson@frlog1001:/srv/archive$ logdog "Exception setting up GatewayPage with adapter class AstroPayAdapter"
##################################################################
# Sniffing /var/log/remote for files matching '*' containing 'Exception setting up GatewayPage with adapter class AstroPayAdapter'


# /var/log/remote/error hits: 20
# Results written to /home/jgleeson/logdog/Exception_setting_up_GatewayPage_with_adapter_class_AstroPayAdapter/error.txt
Aug 12 06:48:58 payments1002 astropay_gateway:  Exception setting up GatewayPage with adapter class AstroPayAdapter: No supported currencies for SG #0 /srv/www/org/wikimedia/payments/extensions/DonationInterface/gateway_common/DataValidator.php(229): AstroPayAdapter->getCurrencies(Array) #1 /srv/www/org/wikimedia/payments/extensions/DonationInterface/gateway_common/gateway.adapter.php(2632): DataValidator::validate(Object(AstroPayAdapter), Array, Array) #2 /srv/www/org/wikimedia/payments/extensions/DonationInterface/gateway_common/gateway.adapter.php(269): GatewayAdapter->validate() #3 /srv/www/org/wikimedia/payments/extensions/DonationInterface/gateway_common/GatewayPage.php(97): GatewayAdapter->__construct(Array) #4 /srv/www/org/wikimedia/payments/includes/specialpage/SpecialPage.php(565): GatewayPage->execute(NULL) #5 /srv/www/org/wikimedia/payments/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL) #6 /srv/www/org/wikimedia/payments/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Object(Title), Object(RequestContext)) #7 /srv/www/org/wikimedia/payments/includes/MediaWiki.php(861): MediaWiki->performRequest() #8 /srv/www/org/wikimedia/payments/includes/MediaWiki.php(524): MediaWiki->main() #9 /srv/www/org/wikimedia/payments/index.php(42): MediaWiki->run() #10 {main}

I feel like they might be related to some of the dlocal duplicate ct issue but I couldn't come up with a quick way to confirm. I'm sure it's doable with a bit more time.