Page MenuHomePhabricator
Create Task
Maniphest T134214

AstroPay: internal exception caused by currency
Closed, ResolvedPublic
Actions

Description

Don't know what this is yet, but I found it in payments.error:

May  2 23:03:22 payments1003 astropay_gateway:  Exception in GatewayPage constructor with adapter class AstropayAdapter: No supported currencies for GB 
 #0 /X/payments/extensions/DonationInterface/gateway_common/DataValidator.php(318): AstropayAdapter->getCurrencies(Array)
 #1 /X/payments/extensions/DonationInterface/gateway_common/DonationData.php(977): DataValidator::validate(Object(AstropayAdapter), Array, Array)
 #2 /X/payments/extensions/DonationInterface/gateway_common/DonationData.php(344): DonationData->getValidationErrors()
 #3 /X/payments/extensions/DonationInterface/gateway_common/DonationData.php(147): DonationData->normalize()
 #4 /X/payments/extensions/DonationInterface/gateway_common/DonationData.php(115): DonationData->populateData(NULL)
 #5 /X/payments/extensions/DonationInterface/gateway_common/gateway.adapter.php(268): DonationData->__construct(Object(AstropayAdapter), NULL)
 #6 /X/payments/extensions/DonationInterface/gateway_common/GatewayPage.php(65): GatewayAdapter->__construct()
 #7 /X/payments/includes/specialpage/SpecialPageFactory.php(410): GatewayPage->__construct()
 #8 /X/payments/includes/specialpage/SpecialPageFactory.php(538): SpecialPageFactory::getPage('AstropayGateway')
 #9 /X/payments/includes/MediaWiki.php(267): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
 #10 X//payments/includes/MediaWiki.php(566): MediaWiki->performRequest()
 #11 X//payments/includes/MediaWiki.php(414): MediaWiki->main()
 #12 X//payments/index.php(41): MediaWiki->run()
 #13 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Stop currency exception in AstroPay constructormediawiki/extensions/DonationInterfacemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.May 2 2016, 11:38 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 2 2016, 11:38 PM
awight added a project: MediaWiki-extensions-DonationInterface.May 2 2016, 11:38 PM
• DStrine moved this task from Triage to Sprint +3 on the Fundraising-Backlog board.May 3 2016, 8:10 PM
• DStrine moved this task from Sprint +3 to Q4 FY21-22 on the Fundraising-Backlog board.Jul 18 2016, 7:19 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:38 PM
• DStrine moved this task from Q4 FY21-22 to Adam's old tasks on the Fundraising-Backlog board.May 6 2019, 8:42 PM
Ejegg mentioned this in T259631: India - Dlocal/Wikimedia message trigger inquiry.Aug 12 2020, 4:04 PM
gerritbot added a comment.Aug 12 2020, 4:25 PM

Change 619785 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Stop currency exception in AstroPay constructor

https://gerrit.wikimedia.org/r/619785

gerritbot added a project: Patch-For-Review.Aug 12 2020, 4:25 PM
Ejegg added a project: Fundraising Sprint Pseudopretzels.Aug 12 2020, 4:26 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Pseudopretzels board.
Ejegg moved this task from Adam's old tasks to Current Sprint on the Fundraising-Backlog board.
MBeat33 subscribed.Aug 12 2020, 6:53 PM
gerritbot added a comment.Aug 12 2020, 7:36 PM

Change 619785 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Stop currency exception in AstroPay constructor

https://gerrit.wikimedia.org/r/619785

Maintenance_bot removed a project: Patch-For-Review.Aug 12 2020, 8:10 PM
jgleeson subscribed.Aug 12 2020, 8:48 PM

Looks like we're getting a few of these a day. I counted 20 for today.

jgleeson@frlog1001:/srv/archive$ logdog "Exception setting up GatewayPage with adapter class AstroPayAdapter"
##################################################################
# Sniffing /var/log/remote for files matching '*' containing 'Exception setting up GatewayPage with adapter class AstroPayAdapter'


# /var/log/remote/error hits: 20
# Results written to /home/jgleeson/logdog/Exception_setting_up_GatewayPage_with_adapter_class_AstroPayAdapter/error.txt
Aug 12 06:48:58 payments1002 astropay_gateway:  Exception setting up GatewayPage with adapter class AstroPayAdapter: No supported currencies for SG #0 /srv/www/org/wikimedia/payments/extensions/DonationInterface/gateway_common/DataValidator.php(229): AstroPayAdapter->getCurrencies(Array) #1 /srv/www/org/wikimedia/payments/extensions/DonationInterface/gateway_common/gateway.adapter.php(2632): DataValidator::validate(Object(AstroPayAdapter), Array, Array) #2 /srv/www/org/wikimedia/payments/extensions/DonationInterface/gateway_common/gateway.adapter.php(269): GatewayAdapter->validate() #3 /srv/www/org/wikimedia/payments/extensions/DonationInterface/gateway_common/GatewayPage.php(97): GatewayAdapter->__construct(Array) #4 /srv/www/org/wikimedia/payments/includes/specialpage/SpecialPage.php(565): GatewayPage->execute(NULL) #5 /srv/www/org/wikimedia/payments/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL) #6 /srv/www/org/wikimedia/payments/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Object(Title), Object(RequestContext)) #7 /srv/www/org/wikimedia/payments/includes/MediaWiki.php(861): MediaWiki->performRequest() #8 /srv/www/org/wikimedia/payments/includes/MediaWiki.php(524): MediaWiki->main() #9 /srv/www/org/wikimedia/payments/index.php(42): MediaWiki->run() #10 {main}

I feel like they might be related to some of the dlocal duplicate ct issue but I couldn't come up with a quick way to confirm. I'm sure it's doable with a bit more time.

Ejegg moved this task from Review to Done on the Fundraising Sprint Pseudopretzels board.Aug 12 2020, 9:31 PM
• DStrine closed this task as Resolved.Aug 18 2020, 7:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits