Maniphest T134310

CentralNotice: don't fail hard if dynamic dependencies of ext.centralNotice.choiceData are incorrect
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

As we saw in T133765, if ext.centralNotice.choiceData receives one or more campaigns, but incorrectly gets no dependencies (for example, due to the RL race condition described in T117587) JS fails hard. Change this to just log an error somewhere in such cases.

Details

	Subject	Repo	Branch	Lines +/-
	Don't fail hard on dependencies error for ext.centralNotice.startUp	mediawiki/extensions/CentralNotice	master	+14 -1

Customize query in gerrit

Related Objects

Mentioned In: T133765: mw.centralNotice CRASH on client side
Mentioned Here: T117587: ResourceLoader should shorten cache max-age if version hash does not match
T133765: mw.centralNotice CRASH on client side

Event Timeline

AndyRussG created this task.May 3 2016, 7:59 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 3 2016, 7:59 PM

AndyRussG claimed this task.May 3 2016, 7:59 PM

AndyRussG set the point value for this task to 1.

Change 286762 had a related patch set uploaded (by AndyRussG):
Don't fail hard on dependencies error for ext.centralNotice.startUp

https://gerrit.wikimedia.org/r/286762

gerritbot added a project: Patch-For-Review.May 3 2016, 10:27 PM

AndyRussG moved this task from Backlog to Review on the Fundraising Sprint Internet Exploring board.May 3 2016, 10:27 PM

AndyRussG mentioned this in T133765: mw.centralNotice CRASH on client side.May 4 2016, 1:58 AM

• DStrine added a project: Fundraising-Backlog.May 4 2016, 3:14 PM

• DStrine moved this task from Triage to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.

• DStrine added a project: Fundraising Sprint Jabberwock Slaying.May 11 2016, 10:22 PM

AndyRussG moved this task from Backlog to Review on the Fundraising Sprint Jabberwock Slaying board.May 11 2016, 10:29 PM

Change 286762 merged by jenkins-bot:
Don't fail hard on dependencies error for ext.centralNotice.startUp

https://gerrit.wikimedia.org/r/286762

AndyRussG moved this task from Review to Pending Deployment on the Fundraising Sprint Jabberwock Slaying board.May 12 2016, 1:40 AM

• DStrine added a project: Fundraising Sprint Killing Time.May 25 2016, 10:18 PM

• DStrine moved this task from Backlog to Pending Deployment on the Fundraising Sprint Killing Time board.May 26 2016, 8:15 PM

• DStrine added a project: Fundraising Sprint Licking Cookies.Jun 8 2016, 10:57 PM

AndyRussG moved this task from Backlog to Pending Deployment on the Fundraising Sprint Licking Cookies board.Jun 8 2016, 11:00 PM

• DStrine added a project: Fundraising Sprint Muggle Baiting.Jul 6 2016, 9:44 PM

awight moved this task from Backlog to Pending Deployment on the Fundraising Sprint Muggle Baiting board.Jul 7 2016, 1:08 AM

AndyRussG closed this task as Resolved.Jul 13 2016, 5:20 PM

AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint Muggle Baiting board.

• DStrine moved this task from Current Sprint & Completed in Q4 1516 to Current Sprint & Completed in Q1 1617 on the Fundraising-Backlog board.Jul 14 2016, 5:26 PM

• DStrine removed a project: Unplanned-Sprint-Work.Aug 3 2016, 5:47 PM