Page MenuHomePhabricator

CentralNotice: don't fail hard if dynamic dependencies of ext.centralNotice.choiceData are incorrect
Closed, ResolvedPublic1 Story Points

Description

As we saw in T133765, if ext.centralNotice.choiceData receives one or more campaigns, but incorrectly gets no dependencies (for example, due to the RL race condition described in T117587) JS fails hard. Change this to just log an error somewhere in such cases.

Details

Related Gerrit Patches:

Event Timeline

AndyRussG created this task.May 3 2016, 7:59 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 3 2016, 7:59 PM
AndyRussG claimed this task.May 3 2016, 7:59 PM
AndyRussG set the point value for this task to 1.

Change 286762 had a related patch set uploaded (by AndyRussG):
Don't fail hard on dependencies error for ext.centralNotice.startUp

https://gerrit.wikimedia.org/r/286762

Change 286762 merged by jenkins-bot:
Don't fail hard on dependencies error for ext.centralNotice.startUp

https://gerrit.wikimedia.org/r/286762

AndyRussG closed this task as Resolved.Jul 13 2016, 5:20 PM