Add presentation stuff for "Apply for Membership"
Closed, ResolvedPublic

Restricted Application added a subscriber: Zppix. · View Herald TranscriptMay 3 2016, 11:57 PM
gabriel-wmde added a comment.EditedMay 4 2016, 3:30 PM

The presentation is a bit more complex than simply writing a presenter, since the membership form is displayed in three scenarios:

  1. The membership form as a standalone page.
  2. The initial form is included as the template 10h16_Membership inside the donation confirmation template 10h16_Bestätigung.
  3. Server-side validation fails and the form needs to be re-displayed.
JeroenDeDauw added a comment.EditedMay 7 2016, 3:06 PM

Can you create dedicated tasks for this then? As I understand it there are 3:

  • Create route and have it invoke the UC
  • Create presenter for standalone page
  • "The other presentation stuff"

Edit: the first one is now at https://phabricator.wikimedia.org/T134691, which this task representing the other two. Please still split as appropriate.

JeroenDeDauw renamed this task from Add route and presenter for "Apply for Membership" to Add presentation stuff for "Apply for Membership".May 8 2016, 6:13 PM
JeroenDeDauw changed the point value for this task from 5 to 9.
JeroenDeDauw changed the point value for this task from 9 to 7.
Lea_WMDE moved this task from Incoming to WMDE Fundraising on the TCB-Team board.May 11 2016, 12:20 PM

Talked to Kai today and found out that pre-populating the fields with donation data is not needed. Edited my comment accordingly.

So 1) and 3) are very similar to the donation use case (and Kai is working on it). I'll create a task for 2)

gabriel-wmde removed the point value for this task.May 13 2016, 8:45 AM

Despite what I said earlier, the membership application form is prefilled with the data previously entered in the donation form. This was done in PR#427