Page MenuHomePhabricator

Adjacent pasted references getting about-merged
Closed, ResolvedPublic8 Estimated Story Points

Description

Paste a Parsoid-generated reference next to itself, or...

Paste two wikitext references next to each other (e.g. <ref>Foo</ref>, then <ref>Bar</ref>).

The latter is not serialised as they are both given the same about attribute and then assumed to be part of the same node.

Event Timeline

This is the same as T126114 and T126169, but for references

Esanders renamed this task from Adjacent pasted wikitext references getting about-merged to Adjacent pasted references getting about-merged.May 4 2016, 12:59 PM
Esanders updated the task description. (Show Details)
Jdforrester-WMF set the point value for this task to 8.

Change 286867 had a related patch set uploaded (by Esanders):
Generate new about attribute when cloning a node

https://gerrit.wikimedia.org/r/286867

Change 286867 merged by jenkins-bot:
Generate new about attribute when cloning a node

https://gerrit.wikimedia.org/r/286867

Change 286911 had a related patch set uploaded (by Jforrester):
Generate new about attribute when cloning a node

https://gerrit.wikimedia.org/r/286911

Change 286911 merged by jenkins-bot:
Generate new about attribute when cloning a node

https://gerrit.wikimedia.org/r/286911

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Hmm. This doesn't seem fixed in master on re-checking.

Ed?

wfm locally, where are you testing?

Not sure if this is what you tested, but this would fail if you pasted twice, because the attribute is only re-generated on copy.

Change 289873 had a related patch set uploaded (by Esanders):
Re-clone linear data on each paste

https://gerrit.wikimedia.org/r/289873

Change 289873 merged by jenkins-bot:
Re-clone linear data on each paste

https://gerrit.wikimedia.org/r/289873