Page MenuHomePhabricator
Create Task
Maniphest T134374

Adjacent pasted references getting about-merged
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Paste a Parsoid-generated reference next to itself, or...

Paste two wikitext references next to each other (e.g. <ref>Foo</ref>, then <ref>Bar</ref>).

The latter is not serialised as they are both given the same about attribute and then assumed to be part of the same node.

Details

SubjectRepoBranchLines +/-
Re-clone linear data on each pasteVisualEditor/VisualEditormaster+8 -2
Generate new about attribute when cloning a nodeVisualEditor/VisualEditorwmf/1.27.0-wmf.23+18 -4
Generate new about attribute when cloning a nodeVisualEditor/VisualEditormaster+18 -4
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.May 4 2016, 12:42 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 4 2016, 12:42 PM
Esanders added a comment.May 4 2016, 12:58 PM

This is the same as T126114 and T126169, but for references

Esanders renamed this task from Adjacent pasted wikitext references getting about-merged to Adjacent pasted references getting about-merged.May 4 2016, 12:59 PM
Esanders updated the task description. (Show Details)
Jdforrester-WMF triaged this task as High priority.May 4 2016, 1:23 PM
Jdforrester-WMF added projects: Cite, VisualEditor-MediaWiki-References.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.May 4 2016, 1:26 PM
gerritbot subscribed.May 4 2016, 3:19 PM

Change 286867 had a related patch set uploaded (by Esanders):
Generate new about attribute when cloning a node

https://gerrit.wikimedia.org/r/286867

gerritbot added a project: Patch-For-Review.May 4 2016, 3:19 PM
gerritbot added a comment.May 4 2016, 4:46 PM

Change 286867 merged by jenkins-bot:
Generate new about attribute when cloning a node

https://gerrit.wikimedia.org/r/286867

gerritbot added a comment.May 4 2016, 4:56 PM

Change 286911 had a related patch set uploaded (by Jforrester):
Generate new about attribute when cloning a node

https://gerrit.wikimedia.org/r/286911

gerritbot added a comment.May 4 2016, 4:59 PM

Change 286911 merged by jenkins-bot:
Generate new about attribute when cloning a node

https://gerrit.wikimedia.org/r/286911

Jdforrester-WMF closed this task as Resolved.May 4 2016, 7:25 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-05-03_(1.27.0-wmf.23)), MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)); removed Patch-For-Review.
Jdforrester-WMF reopened this task as Open.May 4 2016, 10:47 PM
Jdforrester-WMF subscribed.

Hmm. This doesn't seem fixed in master on re-checking.

Ed?

Esanders added a comment.May 20 2016, 2:53 PM

wfm locally, where are you testing?

Esanders added a comment.May 20 2016, 2:56 PM

Not sure if this is what you tested, but this would fail if you pasted twice, because the attribute is only re-generated on copy.

gerritbot added a comment.May 20 2016, 3:13 PM

Change 289873 had a related patch set uploaded (by Esanders):
Re-clone linear data on each paste

https://gerrit.wikimedia.org/r/289873

gerritbot added a project: Patch-For-Review.May 20 2016, 3:13 PM
gerritbot added a comment.May 20 2016, 10:07 PM

Change 289873 merged by jenkins-bot:
Re-clone linear data on each paste

https://gerrit.wikimedia.org/r/289873

Jdforrester-WMF closed this task as Resolved.May 20 2016, 10:12 PM
Jdforrester-WMF edited projects, added MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3)); removed Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL