Page MenuHomePhabricator
Create Task
Maniphest T134386

Wikidata build has faling test Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/#/c/286804/
https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/11019/console

10:06:23 1) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetHtml with data set #0 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...))
10:06:23 getHtml() expects exactly 7 parameters, 5 given
10:06:23 
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:92
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:105
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:157
10:06:23 
10:06:23 2) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetHtml with data set #1 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...), Wikibase\MediaInfo\DataModel\MediaInfoId Object (...))
10:06:23 getHtml() expects exactly 7 parameters, 5 given
10:06:23 
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:92
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:105
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:157
10:06:23 
10:06:23 3) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetHtml with data set #2 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...), Wikibase\MediaInfo\DataModel\MediaInfoId Object (...), Wikibase\DataModel\Term\TermList Object (...), 'en', Wikibase\DataModel\Statement\StatementList Object (...))
10:06:23 getHtml() expects exactly 7 parameters, 5 given
10:06:23 
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:92
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:105
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:157
10:06:23 
10:06:23 4) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetHtml with data set #3 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...), Wikibase\MediaInfo\DataModel\MediaInfoId Object (...), Wikibase\DataModel\Term\TermList Object (...), 'lkt')
10:06:23 getHtml() expects exactly 7 parameters, 5 given
10:06:23 
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:92
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:105
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:157
10:06:23 
10:06:23 5) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetHtml with data set #4 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...), Wikibase\MediaInfo\DataModel\MediaInfoId Object (...), Wikibase\DataModel\Term\TermList Object (...), 'lkt', Wikibase\DataModel\Statement\StatementList Object (...))
10:06:23 getHtml() expects exactly 7 parameters, 5 given
10:06:23 
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:92
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:105
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:157
10:06:23 
10:06:23 6) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testPlaceholderIntegration
10:06:23 getHtml() expects exactly 7 parameters, 5 given
10:06:23 
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:92
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:105
10:06:23 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:326

Related Objects

Event Timeline

JanZerebecki created this task.May 4 2016, 2:07 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 4 2016, 2:07 PM
JanZerebecki triaged this task as Unbreak Now! priority.May 4 2016, 2:08 PM
JanZerebecki updated the task description. (Show Details)
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 4 2016, 2:08 PM
JanZerebecki moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-04-26 board.May 4 2016, 2:09 PM
daniel subscribed.May 4 2016, 4:02 PM

Can't reproduce with current master of Wikibase (e185e960d3543) and MediaInfo (bd4bb05d5b). MediaInfoViewTest passes, and MediaInfoView calls getHtml with 7 parameters, as expected.

daniel added a comment.May 4 2016, 4:04 PM

This was apparently fixed in Ic0e7cd97fc23f5e0e0422208ba66fe940f6b4dcc, see https://gerrit.wikimedia.org/r/#/c/286409/2/src/View/MediaInfoView.php

JanZerebecki added a comment.May 4 2016, 4:11 PM

New build: https://gerrit.wikimedia.org/r/#/c/286891/1

JanZerebecki closed this task as Resolved.May 5 2016, 9:55 AM
JanZerebecki claimed this task.
JanZerebecki moved this task from Backlog to Done on the Wikidata-Sprint-2016-04-26 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL