Page MenuHomePhabricator
Create Task
Maniphest T134452

Spike: Decide whether PayPal Express Checkout is a new gateway, payment method, or account name.
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Be careful how we want to distinguish these transactions. How do they show up in reconciliation reports? How are transaction IDs stored?

Details

SubjectRepoBranchLines +/-
Express Checkout is recorded as PayPalwikimedia/fundraising/crmdeployment+8 -0
Express Checkout is recorded as PayPalwikimedia/fundraising/crmmaster+8 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.May 4 2016, 10:13 PM
Restricted Application added a subscriber: Zppix. · View Herald TranscriptMay 4 2016, 10:13 PM
awight moved this task from Triage to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.May 10 2016, 8:13 PM
• DStrine moved this task from Current Sprint & Completed in Q4 1516 to Sprint +1 on the Fundraising-Backlog board.May 10 2016, 8:14 PM
awight closed this task as a duplicate of T136745: PayPal Express Checkout is missing a payment_method. Decide on one and implement..Jun 8 2016, 3:43 AM
awight reopened this task as Open.Jun 8 2016, 3:46 AM
awight claimed this task.
awight moved this task from Backlog to Campaign ready on the FR-PayPal-ExpressCheckout board.
awight moved this task from Campaign ready to 1-hour test on the FR-PayPal-ExpressCheckout board.
awight merged a task: T136745: PayPal Express Checkout is missing a payment_method. Decide on one and implement..
awight added a project: Fundraising Sprint Killing Time.
awight moved this task from Backlog to Doing on the Fundraising Sprint Killing Time board.
awight added a subscriber: • DStrine.
• DStrine moved this task from Sprint +1 to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.Jun 8 2016, 7:31 PM
• DStrine added a project: Fundraising Sprint Licking Cookies.Jun 8 2016, 10:57 PM
awight moved this task from Backlog to Doing on the Fundraising Sprint Licking Cookies board.Jun 8 2016, 11:08 PM
awight added a comment.Jun 13 2016, 7:26 PM

@Ppena
What do you think about PayPal legacy and express checkout being reconciled separately? Would that be helpful, or a pain?

gerritbot subscribed.Jun 13 2016, 8:49 PM

Change 294123 had a related patch set uploaded (by Awight):
Express Checkout is recorded as PayPal

https://gerrit.wikimedia.org/r/294123

gerritbot added a project: Patch-For-Review.Jun 13 2016, 8:49 PM
awight moved this task from Doing to Review on the Fundraising Sprint Licking Cookies board.Jun 13 2016, 8:49 PM
gerritbot added a comment.Jun 13 2016, 9:58 PM

Change 294123 merged by jenkins-bot:
Express Checkout is recorded as PayPal

https://gerrit.wikimedia.org/r/294123

gerritbot added a comment.Jun 13 2016, 10:05 PM

Change 294181 had a related patch set uploaded (by Awight):
Express Checkout is recorded as PayPal

https://gerrit.wikimedia.org/r/294181

gerritbot added a comment.Jun 13 2016, 10:08 PM

Change 294181 merged by jenkins-bot:
Express Checkout is recorded as PayPal

https://gerrit.wikimedia.org/r/294181

awight moved this task from Review to Doing on the Fundraising Sprint Licking Cookies board.Jun 13 2016, 10:56 PM

Back on the table... I've reverted the crm patch because it was causing duplicate contributions (and TY letters). The listener and audit processors are a blocker, they would need to be able to distinguish paypal from paypal_ec in order to send a message with the right gateway, and to dedupe before sending.

awight added a comment.Jun 15 2016, 9:05 PM

Okay, we're still planning to use gateway='paypal' vs 'paypal_ec'.

awight closed this task as Resolved.Jun 15 2016, 9:05 PM
• DStrine moved this task from Doing to Done on the Fundraising Sprint Licking Cookies board.Jul 5 2016, 4:08 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL