ve.ce.FocusableNode throws an error on selecting an about group containing a top-level whitespace text node
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	dchan
	May 5 2016, 6:22 AM

Description

In VE standalone, load <p><span about="x" rel="ve:Alien">Foo</span> <a about="x" rel="ve:Alien" href="foo">Bar</a></p>
Cursor right
Observe the error in ve.ce.FocusableNode where node.classList.contains is accessed on a text node

The error happens with any text node (it needn't be whitespace) or comment node. If we want to ban top-level text nodes/comment nodes from about groups altogether (including whitespace) we should modify getAboutGroup in ve.dm.Converter to reflect that. Else we should handle these things correctly.

Details

	Subject	Repo	Branch	Lines +/-
	Split about groups on text nodes	VisualEditor/VisualEditor	master	+52 -18

Customize query in gerrit

Related Objects

Mentioned In: T133608: Cursor ends up inside template in Flow mention inspector (and possibly other inline templates)

Event Timeline

dchan created this task.May 5 2016, 6:22 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 5 2016, 6:22 AM

dchan updated the task description. (Show Details)May 5 2016, 6:23 AM

Per discussion this should be treated as two separate groups. About grouping is only supposed to work on sibling elements, so top level text nodes must be wrapped.

Esanders mentioned this in T133608: Cursor ends up inside template in Flow mention inspector (and possibly other inline templates).May 6 2016, 10:17 AM

Change 287199 had a related patch set uploaded (by Esanders):
Split about groups on text nodes

https://gerrit.wikimedia.org/r/287199

gerritbot added a project: Patch-For-Review.May 6 2016, 11:44 AM

Jdforrester-WMF assigned this task to Esanders.May 9 2016, 3:29 PM

Jdforrester-WMF triaged this task as High priority.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Jdforrester-WMF set the point value for this task to 8.

Jdforrester-WMF closed this task as Resolved.Jun 1 2016, 4:55 PM

Jdforrester-WMF edited projects, added MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)); removed Patch-For-Review.

Change 287199 merged by jenkins-bot:
Split about groups on text nodes