Page MenuHomePhabricator

1.28.0-alpha / Special:Search search button is being misplaced
Closed, ResolvedPublic

Description

The following observation was made using:

MediaWiki 1.28.0-alpha
PHP 5.6.8
MySQL 5.6.24
Vector – (ed27188)


and compares to a previous release

Event Timeline

mwjames created this task.May 5 2016, 7:33 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 5 2016, 7:33 AM
Restricted Application added projects: Discovery, Discovery-Search. · View Herald TranscriptMay 5 2016, 12:18 PM

I think @Florian wrote the patch that converted Special:Search to OOUI? @Jdforrester-WMF would probably know. @Florian, could you take a look at this?

This is actually broken in production.

Everything looks fine, until you zoom in a bit too much...

Oh dear!

I wrote the change, yes, but this is the default behaviour of OOJsUI, as far as I can tell. What would be the expected behaviour, so I can look how we can achieve it :)

@Florian It would probably be best for the search bar to get less wide to fit the search button in, down to some minimum so that it doesn't go arbitrarily small. Does that make sense to you?

Change 288764 had a related patch set uploaded (by Florianschmidtwelzow):
SpecialSearch: Use OOUI\FieldLayout for search input and button

https://gerrit.wikimedia.org/r/288764

Change 288764 merged by jenkins-bot:
SpecialSearch: Use OOUI\ActionFieldLayout for search input and button

https://gerrit.wikimedia.org/r/288764

matmarex closed this task as Resolved.May 28 2016, 5:01 PM
matmarex assigned this task to Florian.
matmarex removed a project: Patch-For-Review.