Page MenuHomePhabricator
Create Task
Maniphest T134523

Jolokia server causes FD leak in Updater
Closed, ResolvedPublic
Actions

Description

WDQS Updater monitoring uses Jolokia server to fetch the data. It starts-stops the server each time it needs to fetch data, which is wasteful but also leaks 3 FDs each time. We should instead make Jolokia dependent service and start it when Updater starts.

Details

ProjectBranchLines +/-Subject
operations/puppetproduction+7 -9Don't start Jolokia each time, let Updater start it
wikidata/query/rdfmaster+2 -1Start Jolokia together with Updater
Customize query in gerrit

Related Objects

Event Timeline

Smalyshev created this task.May 5 2016, 6:46 PM
Restricted Application added projects: Wikidata, Discovery-ARCHIVED. · View Herald TranscriptMay 5 2016, 6:46 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript
gerritbot added a subscriber: gerritbot.May 5 2016, 6:46 PM

Change 287128 had a related patch set uploaded (by Smalyshev):
Start Jolokia together with Updater

https://gerrit.wikimedia.org/r/287128

gerritbot added a project: Patch-For-Review.May 5 2016, 6:46 PM
gerritbot added a comment.May 5 2016, 6:57 PM

Change 287131 had a related patch set uploaded (by Smalyshev):
Don't start Jolokia each time, let Updater start it

https://gerrit.wikimedia.org/r/287131

gerritbot added a comment.May 5 2016, 7:00 PM

Change 287128 merged by jenkins-bot:
Start Jolokia together with Updater

https://gerrit.wikimedia.org/r/287128

Smalyshev triaged this task as Medium priority.May 5 2016, 8:14 PM
Smalyshev mentioned this in T134238: Query service fails with "Too many open files".
Smalyshev added a project: Discovery-Wikidata-Query-Service-Sprint.
Smalyshev moved this task from Backlog to Needs review on the Discovery-Wikidata-Query-Service-Sprint board.
Smalyshev moved this task from Needs triage to WDQS on the Discovery-ARCHIVED board.May 6 2016, 8:51 PM
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.May 9 2016, 9:04 AM
gerritbot added a comment.May 9 2016, 5:25 PM

Change 287131 merged by Gehel:
Don't start Jolokia each time, let Updater start it

https://gerrit.wikimedia.org/r/287131

Smalyshev closed this task as Resolved.May 9 2016, 8:15 PM
Diffusion mentioned this in rOPUPc1573487f5bb: Don't start Jolokia each time, let Updater start it.Jun 17 2016, 6:10 PM
Smalyshev moved this task from Needs review to Done on the Discovery-Wikidata-Query-Service-Sprint board.Aug 3 2016, 5:55 PM
Smalyshev removed a project: Discovery-Wikidata-Query-Service-Sprint.Jul 14 2017, 10:31 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL