[betalabs] Regression: asynchronous update for cross-wiki notifications
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	May 5 2016, 9:41 PM

Description

Easier to explain with a totally new user.

As a new user login into two different wikis - e.g. enwiki and cawiki.
The notifications count will be in exact match between two wikis. 'Welcome' notification will be displayed as the Alert from enwiki in cawiki and, of course, in enwiki - correct behavior.
Generate some notifications for the in enwiki - the number of notifications will be correctly calculated and displayed in enwiki, but not in cawiki.

The counter does not get updated. Not on refreshing the page and not upon log out/log in. Marking notifications as read in enwiki will trigger all kinds of odd counter states:

Screen Shot 2016-05-05 at 2.36.10 PM.png (226×623 px, 24 KB)

Screen Shot 2016-05-05 at 2.23.49 PM.png (240×572 px, 34 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use global user ID in global cache keys	mediawiki/extensions/Echo	REL1_27	+54 -15
	Use global user ID in global cache keys	mediawiki/extensions/Echo	master	+54 -15

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T119713 Update Help:Notifications
Resolved		None	T114351 Better organisation for the Notification System
Open		None	T100528 Improve organization and control for Flow notifications (tracking + ideas)
Resolved		None	T113228 Better organization for the Notification panel
Open	Feature	None	T66475 Make crosswiki bits and pieces truly global (tracking)
Invalid		Wikinaut	T3932 [DO NOT USE] ENotif/EConfirm & further enhancements (tracking) [superseded by #MediaWiki-Email]
Resolved		Catrope	T3066 Please add cross-wiki talk page notification.
Resolved		Catrope	T114350 Notifications Panel: Support cross-wiki notifications
Resolved		Catrope	T130655 Enable cross-wiki notifications by default
Resolved		Catrope	T133623 Cache foreign notification count in memcached
Resolved		Catrope	T134533 [betalabs] Regression: asynchronous update for cross-wiki notifications

Event Timeline

Etonkovidova created this task.May 5 2016, 9:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2016, 9:41 PM

Etonkovidova edited projects, added Collab-Team-2016-Apr-Jun-Q4; removed acl*security.May 5 2016, 9:42 PM

Restricted Application added a project: acl*security. · View Herald TranscriptMay 5 2016, 9:42 PM

Etonkovidova removed a project: acl*security.May 5 2016, 9:42 PM

Was this made a security issue on purpose? I noticed the order of the "Create Task" dropdown in Phab changed yesterday, so I'm wondering if this was by accident...

I'm not seeing the security impact, if this was intentional, so maybe I need a better explanation of the problem in that case.

Etonkovidova added a parent task: T130636: Cross-wiki notifications: Make cross-wiki API requests server-side.May 5 2016, 10:06 PM

re-adding security tag while this has a non-public visibility policy

Etonkovidova removed a parent task: T130636: Cross-wiki notifications: Make cross-wiki API requests server-side.May 5 2016, 10:23 PM

Etonkovidova added a parent task: T133623: Cache foreign notification count in memcached.

This is not a security issue, I see no reason this task shouldn't be made public.

Catrope claimed this task.May 6 2016, 12:09 AM

Catrope removed a project: acl*security.

Catrope changed the visibility from "Custom Policy" to "Public (No Login Required)".

Catrope changed Security from Software security bug to None.

Catrope added a project: Notifications (Echo).

Catrope moved this task from Untriaged to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.

Change 287153 had a related patch set uploaded (by Catrope):
Use global user ID in global cache keys

https://gerrit.wikimedia.org/r/287153

gerritbot added a project: Patch-For-Review.May 6 2016, 12:10 AM

SBisson moved this task from Needs Review to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.May 6 2016, 3:22 PM

• csteipp unsubscribed.May 6 2016, 3:44 PM

Change 287153 merged by jenkins-bot:
Use global user ID in global cache keys

https://gerrit.wikimedia.org/r/287153

Danny_B added a project: Regression.May 8 2016, 2:11 PM

Checked in betalabs - all counts are correct.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.May 9 2016, 5:01 PM

Etonkovidova mentioned this in T133623: Cache foreign notification count in memcached.May 9 2016, 8:52 PM

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)).May 10 2016, 1:08 PM

• jmatazzoni closed this task as Resolved.May 12 2016, 5:47 PM

Change 295112 had a related patch set uploaded (by Catrope):
Use global user ID in global cache keys

https://gerrit.wikimedia.org/r/295112

Change 295112 merged by Catrope:
Use global user ID in global cache keys