Maniphest T134545

Separate user input errors from other InvalidInputException, then make re-loggable
Closed, ResolvedPublic
Actions

Assigned To

• Mattflaschen-WMF

Authored By

	• Mattflaschen-WMF
	May 6 2016, 2:06 AM

Project Tags

Referenced Files

	F3088923: 9lK2QDG.png
	May 6 2016, 2:06 AM

Subscribers

• Mattflaschen-WMF

Description

The user input errors should not be loggable. The rest should be.

See https://gerrit.wikimedia.org/r/#/c/287152/ and T121455: Error with Flow beta feature at cawiki - InvalidInputException.

9lK2QDG.png (970×358 px, 32 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make more types of exceptions loggable	mediawiki/extensions/Flow	wmf/1.28.0-wmf.21	+75 -40
	Make more types of exceptions loggable	mediawiki/extensions/Flow	master	+75 -40

Customize query in gerrit

Related Objects

Mentioned In: T138310: Flow as a Beta feature: enable, disable and reenable doesn't seem to work
Mentioned Here: T121455: Error with Flow beta feature at cawiki - InvalidInputException

Event Timeline

• Mattflaschen-WMF created this task.May 6 2016, 2:06 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 6 2016, 2:06 AM

• Mattflaschen-WMF moved this task from Untriaged to Near-Term Interest on the Collaboration-Team-Triage board.May 6 2016, 2:06 AM

• Mattflaschen-WMF mentioned this in T138310: Flow as a Beta feature: enable, disable and reenable doesn't seem to work.Oct 4 2016, 4:54 AM

Change 314197 had a related patch set uploaded (by Mattflaschen):
WIP: Make more types of exceptions loggable

https://gerrit.wikimedia.org/r/314197

gerritbot added a project: Patch-For-Review.Oct 4 2016, 10:56 PM

• Mattflaschen-WMF edited projects, added: Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016); removed: Collaboration-Team-Triage.Oct 5 2016, 2:48 AM

• Mattflaschen-WMF moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.

Change 314197 merged by jenkins-bot:
Make more types of exceptions loggable

https://gerrit.wikimedia.org/r/314197

Change 314452 had a related patch set uploaded (by Catrope):
Make more types of exceptions loggable

https://gerrit.wikimedia.org/r/314452

Change 314452 merged by jenkins-bot:
Make more types of exceptions loggable

https://gerrit.wikimedia.org/r/314452

This was deployed to 1.28.0-wmf.21.

Catrope closed this task as Resolved.Oct 7 2016, 9:08 PM

Catrope claimed this task.

• Mattflaschen-WMF claimed this task.Dec 3 2016, 1:24 AM

• Mattflaschen-WMF added a subscriber: Catrope.