Page MenuHomePhabricator

Make ApiRevThankIntegrationTest->newRevId non-flaky
Closed, ResolvedPublic

Description

It randomly fails (@Addshore saw it 3 times in one week).

I notice it uses random page names and doesn't clear the DB tables. I'm not sure that is enough to explain the null revision though (page names alone would be a pretty likely collision, but if it's the same page name but different text it should still save an edit).

To start with, it should:

  • Add 'page', 'revision', and 'text' to $this->tablesUsed so those tables reset.
  • Use deterministic page names and content (no random).
  • If the revision is null, throw an exception showing what the status error was. It could be just 'edit-no-change' (null edit) (though that shouldn't happen with deterministic page names and content, but maybe it's something weird we're not considering.

Details

Related Gerrit Patches:
mediawiki/extensions/Thanks : masterMake revisions in setUp for ApiRevThankIntTest

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 6 2016, 2:51 PM

Change 287220 had a related patch set uploaded (by Addshore):
Make revisions in setUp for ApiRevThankIntTest

https://gerrit.wikimedia.org/r/287220

Change 287220 merged by jenkins-bot:
Make revisions in setUp for ApiRevThankIntTest

https://gerrit.wikimedia.org/r/287220

Addshore closed this task as Resolved.May 11 2016, 8:42 AM