Page MenuHomePhabricator

Convert Special:MergeHistory to OOUI
Open, MediumPublic



MergeHistory old.png (401×1 px, 56 KB)

Event Timeline

Change 287435 had a related patch set uploaded (by Sethakill):
Convert Special:MergeHistory to use OOUI.

Change 287435 merged by jenkins-bot:
Convert Special:MergeHistory to use OOUI.

Hi @Sethakill. I just used this tool for the first time since your change here went live. I'm not sure exactly how to word this, but is there any chance that we could go back to if no revision/button is selected and I hit "merge revisions" it just merges all the revisions? This is I think how it used to be and also how it works for undeletions (i.e. it's assumed you want all of it unless you specify otherwise).

I'm not sure if what I'm asking for is a simple or difficult change. Also wasn't sure if I should create a new bug or just comment on this one, please let me know if I need to do anything differently.

Hi @Jenks24 I'd suggest creating a new bug trying to explain replication steps. Can you add some screenshots too?

Open page X
Click radio button next to this item.
Expected: This should happen which makes me happy
Actual: This happens which makes me sad

@Sethakill Again a before screenshot would be appreciated (after @Jdlrobson added the after already), please! That'd be beneficial for all 'Conversion to OOjs UI' tasks. We want to make sure from design and UX perspective that the changes are not introducing experience regressions.

Sorry about troubles. I will set new patch in a moment.

Change 302092 had a related patch set uploaded (by Sethakill):
Convert Special:MergeHistory to use OOUI.

Not to forget about when form is transformed from HTMLForm to OOUI: First button should not be a primary button, but solely a progressive one.

@Sethakill: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or do you need any help?

If this task has been resolved in the meantime: Please update the task status (via Add Action...Change Status in the dropdown menu).
If this task is not resolved and only if you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action...Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)

@Sethakill: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action...Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

DannyS712 removed a project: User-DannyS712.