Page MenuHomePhabricator

template_bot_tests fails for unknown reason
Closed, ResolvedPublic

Description

with deactivated unittest.expectedFailure decorator TestXMLPageGenerator.test_match_unnecessary_template_prefix ("""Test pages with {{template:..}}.""") fails

C:\pwb\GIT\core>pwb.py tests/template_bot_tests -v TestXMLPageGenerator.test_mat
ch_unnecessary_template_prefix
tests: max_retries reduced from 25 to 1
test_match_unnecessary_template_prefix (__main__.TestXMLPageGenerator)
Test pages with {{template:..}}. ... FAIL

======================================================================
FAIL: test_match_unnecessary_template_prefix (__main__.TestXMLPageGenerator)
Test pages with {{template:..}}.
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\tests\template_bot_tests.py", line 124, in test_match_unnecessary_temp
late_prefix
    self.assertEqual(len(pages), 1)
AssertionError: 0 != 1

----------------------------------------------------------------------
Ran 1 test in 0.009s

FAILED (failures=1)

Either this should be solved or the test should be modified.

Event Timeline

Xqt triaged this task as High priority.
Xqt added a subscriber: jayvdb.

Change 288312 had a related patch set uploaded (by Mpaa):
textlib.py: template prefix is case-insensitive in template prefixes

https://gerrit.wikimedia.org/r/288312

Change 287437 had a related patch set uploaded (by Xqt):
[bugfix] fix for template_bot_tests

https://gerrit.wikimedia.org/r/287437

Change 288312 abandoned by Mpaa:
textlib.py: template prefix is case-insensitive in template prefixes

Reason:
see comment

https://gerrit.wikimedia.org/r/288312

Change 287437 had a related patch set uploaded (by Xqt):
[bugfix] fix for template_bot_tests

https://gerrit.wikimedia.org/r/287437

Change 287437 merged by jenkins-bot:
[bugfix] fix for template_bot_tests

https://gerrit.wikimedia.org/r/287437

Change 291577 had a related patch set uploaded (by John Vandenberg):
Adjust recent added tests for case-sensitive site

https://gerrit.wikimedia.org/r/291577

Change 291577 merged by jenkins-bot:
Adjust recent added tests for case-sensitive site

https://gerrit.wikimedia.org/r/291577