Page MenuHomePhabricator

[Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases
Closed, ResolvedPublic

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenFeatureNone
DuplicateNone
ResolvedNone
ResolvedNone
ResolvedNone
DuplicateNone
InvalidLydia_Pintscher
OpenNone
OpenNone
StalledNone
OpenNone
ResolvedAddshore
Resolvedthiemowmde
ResolvedAddshore
Resolvedthiemowmde
Resolvedthiemowmde
Resolvedthiemowmde

Event Timeline

Change 287580 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Make use of Label/DescriptionProvider interfaces in history/search

https://gerrit.wikimedia.org/r/287580

Can you create a subtask for each change you're doing on this thing? I'd call this tracking, not task, too.

Can you create a subtask for each change you're doing on this thing? I'd call this tracking, not task, too.

I imagine there are maaany places to touch for this :O

Change 287580 merged by jenkins-bot:
Make use of Label/DescriptionProvider interfaces in history/search

https://gerrit.wikimedia.org/r/287580

Change 290461 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Make terms table compatible with MediaInfo

https://gerrit.wikimedia.org/r/290461

Change 290900 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Runtime optimizations and more narrow interfaces in TermSqlIndex

https://gerrit.wikimedia.org/r/290900

Change 290900 merged by jenkins-bot:
Runtime optimizations and more narrow interfaces in TermSqlIndex

https://gerrit.wikimedia.org/r/290900

Change 290461 merged by jenkins-bot:
Make terms table compatible with MediaInfo

https://gerrit.wikimedia.org/r/290461

Change 335463 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused interface from LabelUniquenessValidator

https://gerrit.wikimedia.org/r/335463

Change 335464 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace unused CompositeFingerprintValidator with null implementation

https://gerrit.wikimedia.org/r/335464

Change 335614 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove Fingerprint from FingerprintValidator interface

https://gerrit.wikimedia.org/r/335614

Change 335615 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove Fingerprint interface from label & description ChangeOps

https://gerrit.wikimedia.org/r/335615

Change 335617 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Simplify TermValidatorFactoryTest setup to not use Fingerprint

https://gerrit.wikimedia.org/r/335617

Change 335463 merged by jenkins-bot:
Remove unused interface from LabelUniquenessValidator

https://gerrit.wikimedia.org/r/335463

Change 335464 merged by jenkins-bot:
Replace unused CompositeFingerprintValidator with null implementation

https://gerrit.wikimedia.org/r/335464

Change 335614 merged by jenkins-bot:
Remove Fingerprint from FingerprintValidator interface

https://gerrit.wikimedia.org/r/335614

Change 335615 merged by jenkins-bot:
Remove Fingerprint interface from label & description ChangeOps

https://gerrit.wikimedia.org/r/335615

Change 335617 merged by jenkins-bot:
Simplify TermValidatorFactoryTest setup to not use Fingerprint

https://gerrit.wikimedia.org/r/335617

Change 337849 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix TermView components assuming all entities have labels/descriptions

https://gerrit.wikimedia.org/r/337849

Change 339912 had a related patch set uploaded (by Ladsgroup):
Remove Fingerprint from the backend

https://gerrit.wikimedia.org/r/339912

I just checked again (as I already did dozens of times in the pasts months) and found that the biggest remaining issues are:

  • https://gerrit.wikimedia.org/r/337849 not merged after almost 2 weeks.
  • EntityRetrievingTermLookup still binds against FingerprintProvider instead of individual Labels/Descriptions/AliasesProvider.

Change 339912 merged by jenkins-bot:
Remove Fingerprint from the backend

https://gerrit.wikimedia.org/r/339912

Change 340135 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused code from TermView components and tests

https://gerrit.wikimedia.org/r/340135

Change 337849 merged by jenkins-bot:
Fix TermView components assuming all entities have labels/descriptions

https://gerrit.wikimedia.org/r/337849

Change 340135 merged by jenkins-bot:
Remove unused code from TermView components and tests

https://gerrit.wikimedia.org/r/340135

thiemowmde removed a project: Patch-For-Review.
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.