Page MenuHomePhabricator

Document use of common directory in heritage
Open, Needs TriagePublic

Description

Taking a look at the common directory in the repo it looks like this only contains legacy stuff from when erfgoedbot lived on the toolserver. I also can't see anything using these files that is live right now.

Unless we are using this somewhere I would suggest dropping that directory to reduce the clutter in the repo.

I added @Platonides as a subscriber since his name shows up in that code (but that might just mean it has been copy-pasted from somewhere else)

Event Timeline

Lokal_Profil renamed this task from Drop common directory to Drop common directory in heritage.May 9 2016, 2:34 PM
Lokal_Profil moved this task from Backlog to Internals on the Wiki-Loves-Monuments board.

@Lokal_Profil : Just to be clear, what is the full path?

@Lokal_Profil : Just to be clear, what is the full path?

It's in the root directory so heritage/common/

It seems to be used by https://tools.wmflabs.org/heritage/tools/wlm/gallery-all.php, albeit apparently it's non-working right now (I think mediawiki needed some patch that is absent).

@Platonides Thanks for identifying the usage.

Would you mind taking gallery-all.php through the steps in T131743? i.e. works?/keep?/index, might then also be worth adding a note that it is the consumer of /common/.

Lokal_Profil renamed this task from Drop common directory in heritage to Document use of common directory in heritage.May 17 2016, 9:38 PM