Page MenuHomePhabricator

imagemagick::install refers to directory /etc/ImageMagic which does not exist on Jessie
Closed, ResolvedPublic

Description

$ git grep -n /etc/ImageMagick
modules/imagemagick/manifests/install.pp:7:    file { '/etc/ImageMagick/policy.xml':
modules/ocg/templates/usr.bin.nodejs.apparmor.erb:74:    /etc/ImageMagick/** r,

But on Jessie instance integration-slave-jessie1001 puppet complains:

Error: /Stage[main]/Imagemagick::Install/File[/etc/ImageMagick/policy.xml]/ensure:
    change from absent to file failed: Could not set 'file' on ensure:
    No such file or directory @ dir_s_rmdir -
    /etc/ImageMagick/policy.xml20160509-27249-13fxwsr.lock at 14:/etc/puppet/modules/imagemagick/manifests/install.pp

That is because on Jessie the config dir is /etc/ImageMagick-6

Event Timeline

Change 287642 had a related patch set uploaded (by Faidon Liambotis):
imagemagick: fix policy.xml path for newer versions

https://gerrit.wikimedia.org/r/287642

Change 287642 merged by Faidon Liambotis:
imagemagick: fix policy.xml path for newer versions

https://gerrit.wikimedia.org/r/287642

That fixed it on integration-slave-jessie1001 :-}

OCG would also need a fix for whenever it is switched to Jessie.

modules/ocg/templates/usr.bin.nodejs.apparmor.erb:    /etc/ImageMagick/** r,

Change 288142 had a related patch set uploaded (by Dzahn):
ocg: set correct ImageMagick conf dir on jessie

https://gerrit.wikimedia.org/r/288142

OCG servers are being reinstalled apparently to Jessie (T84723) @Dzahn fixed the apparmor profile https://gerrit.wikimedia.org/r/#/c/288142/

There is nothing left to do!