[Regression wmf.23] Cannot switch to Read tab from VE, getting error "this.emit is not a function"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

[Regression wmf.23]

Steps to reproduce:

Open a page with VE
Make some edits
Click on Read
When the dialog appears click on "Discard Edit"

Observed Result:
The following error appears in the console and it does not switch to Read tab
"Uncaught TypeError: this.emit is not a function"

Screen Shot 2016-05-09 at 6.36.41 PM.png (725×1 px, 286 KB)

Details

Subject	Repo	Branch	Lines +/-
Fix deactivating VE after user explicitly decideas to discard changes	mediawiki/extensions/VisualEditor	REL1_27	+1 -1
Update VE-MW submodule to wmf/1.28.0-wmf.1 HEAD (e16be2a)	mediawiki/core	wmf/1.28.0-wmf.1	+1 -1
Update VE-MW submodule to wmf/1.27.0-wmf.23 HEAD (03d066f)	mediawiki/core	wmf/1.27.0-wmf.23	+1 -1
Fix deactivating VE after user explicitly decideas to discard changes	mediawiki/extensions/VisualEditor	wmf/1.28.0-wmf.1	+1 -1
Fix deactivating VE after user explicitly decideas to discard changes	mediawiki/extensions/VisualEditor	wmf/1.27.0-wmf.23	+1 -1
Fix deactivating VE after user explicitly decideas to discard changes	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T143042: Clicking on the "Discard Changes" button causes an error on REL1_27
Mentioned Here: rEVEDe16be2a2698d: Fix deactivating VE after user explicitly decideas to discard changes
rEVED03d066f67d20: Fix deactivating VE after user explicitly decideas to discard changes

Event Timeline

Ryasmeen created this task.May 9 2016, 5:37 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 9 2016, 5:37 PM

Danny_B renamed this task from [Regression wmf.23] Cannot switch to Read tab from VE, getting error "this.emit is not a function" to Cannot switch to Read tab from VE, getting error "this.emit is not a function" .May 9 2016, 8:56 PM

Danny_B added a project: Regression.

Danny_B updated the task description. (Show Details)

Ryasmeen renamed this task from Cannot switch to Read tab from VE, getting error "this.emit is not a function" to [Regression wmf.23] Cannot switch to Read tab from VE, getting error "this.emit is not a function" .May 10 2016, 12:58 PM

Jdforrester-WMF triaged this task as High priority.May 10 2016, 7:07 PM

Jdforrester-WMF added a project: VisualEditor-MediaWiki.

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Looks like this was my fault in https://gerrit.wikimedia.org/r/#/c/283591/

Change 288110 had a related patch set uploaded (by Alex Monk):
Fix deactivating VE after user explicitly decideas to discard changes

https://gerrit.wikimedia.org/r/288110

gerritbot added a project: Patch-For-Review.May 10 2016, 10:40 PM

Change 288110 merged by jenkins-bot:
Fix deactivating VE after user explicitly decideas to discard changes

https://gerrit.wikimedia.org/r/288110

Change 288114 had a related patch set uploaded (by Jforrester):
Fix deactivating VE after user explicitly decideas to discard changes

https://gerrit.wikimedia.org/r/288114

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-17_(1.28.0-wmf.2)).May 10 2016, 11:00 PM

Change 288115 had a related patch set uploaded (by Jforrester):
Fix deactivating VE after user explicitly decideas to discard changes

https://gerrit.wikimedia.org/r/288115

Change 288115 merged by jenkins-bot:
Fix deactivating VE after user explicitly decideas to discard changes

https://gerrit.wikimedia.org/r/288115

Change 288114 merged by jenkins-bot:
Fix deactivating VE after user explicitly decideas to discard changes

https://gerrit.wikimedia.org/r/288114

• Elitre subscribed.May 10 2016, 11:13 PM

Change 288126 had a related patch set uploaded (by Jforrester):
Update VE-MW submodule to wmf/1.27.0-wmf.23 HEAD (rEVED03d066f67d20)

https://gerrit.wikimedia.org/r/288126

Change 288127 had a related patch set uploaded (by Jforrester):
Update VE-MW submodule to wmf/1.28.0-wmf.1 HEAD (rEVEDe16be2a2698d)

https://gerrit.wikimedia.org/r/288127

Jdforrester-WMF closed this task as Resolved.May 10 2016, 11:27 PM

Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.

Jdforrester-WMF edited projects, added MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)), MW-1.27-release (WMF-deploy-2016-05-03_(1.27.0-wmf.23)); removed Patch-For-Review.

Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 10 2016, 11:27 PM

Change 288126 merged by jenkins-bot:
Update VE-MW submodule to wmf/1.27.0-wmf.23 HEAD (rEVED03d066f67d20)

https://gerrit.wikimedia.org/r/288126

Change 288127 merged by jenkins-bot:
Update VE-MW submodule to wmf/1.28.0-wmf.1 HEAD (rEVEDe16be2a2698d)

https://gerrit.wikimedia.org/r/288127

Mentioned in SAL [2016-05-10T23:49:10Z] <dereckson@tin> Synchronized php-1.27.0-wmf.23/extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js: Fix 'Uncaught TypeError: this.emit is not a function' (T134794) (duration: 00m 28s)

Mentioned in SAL [2016-05-10T23:52:27Z] <dereckson@tin> Synchronized php-1.28.0-wmf.1/extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js: Fix 'Uncaught TypeError: this.emit is not a function' (T134794) (duration: 00m 25s)

Ryasmeen added a project: Verified.May 11 2016, 3:18 PM

Ryasmeen added a project: Verified-in-Phase0.

DLynch mentioned this in T143042: Clicking on the "Discard Changes" button causes an error on REL1_27.Aug 16 2016, 2:59 PM

Change 304882 had a related patch set uploaded (by Juanmi 1041):
Fix deactivating VE after user explicitly decides to discard changes

https://gerrit.wikimedia.org/r/304882

gerritbot added a project: Patch-For-Review.Aug 16 2016, 3:32 PM

Change 304882 merged by Jforrester:
Fix deactivating VE after user explicitly decideas to discard changes