Page MenuHomePhabricator
Create Task
Maniphest T134841

MessageGroupStats::queueUpdates trigger on page views
Closed, ResolvedPublic
Actions

Description

Seen on /wiki/Special:LanguageStats:

Expectation (masterConns <= 0) by MediaWiki::main not met:
[connect to 10.64.16.30 (metawiki)]
TransactionProfiler.php line 311 calls wfBacktrace()
TransactionProfiler.php line 146 calls TransactionProfiler->reportExpectationViolated()
LoadBalancer.php line 571 calls TransactionProfiler->recordConnection()
GlobalFunctions.php line 3122 calls LoadBalancer->getConnection()
MessageGroupStats.php line 463 calls wfGetDB()
MessageGroupStats.php line 113 calls MessageGroupStats::queueUpdates()
SpecialLanguageStats.php line 370 calls MessageGroupStats::forLanguage()
SpecialLanguageStats.php line 157 calls SpecialLanguageStats->getTable()
SpecialPage.php line 417 calls SpecialLanguageStats->execute()
SpecialPageFactory.php line 572 calls SpecialPage->run()
MediaWiki.php line 282 calls SpecialPageFactory::executePath()
MediaWiki.php line 745 calls MediaWiki->performRequest()
MediaWiki.php line 519 calls MediaWiki->main()
index.php line 43 calls MediaWiki->run()
index.php line 3 calls include()

Related Objects
Search...

Event Timeline

aaron created this task.May 10 2016, 5:16 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMay 10 2016, 5:16 AM
Restricted Application added a subscriber: Zppix. · View Herald Transcript
aaron removed aaron as the assignee of this task.May 10 2016, 5:51 AM
Glaisher added a project: MediaWiki-extensions-Translate.May 10 2016, 5:54 AM
Nikerabbit merged a task: T70530: Many INSERT queries on some web requests.May 10 2016, 6:03 AM
Nikerabbit added subscribers: siebrand, dchan, • wikibugs-l-list, Nikerabbit.

See the merged bug as well as https://phabricator.wikimedia.org/T95753#2269427 for more info and related issues.

Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.May 10 2016, 6:04 AM
Nikerabbit added a comment.May 17 2016, 8:57 AM

https://gerrit.wikimedia.org/r/#/c/288760/ pushes these do DeferredUpdates.

Ladsgroup subscribed.Aug 29 2017, 2:32 PM

Is this related? https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2017.08.29/mediawiki?id=AV4uWfM5vZW3qLiuPQ-o

Nikerabbit added a comment.Aug 30 2017, 6:21 PM

Pretty much the same thing, yes. Only now it's deferred until end of request.

Nikerabbit added a comment.Nov 1 2018, 7:33 AM

I have made further changes to this code. Not only should this be more rare, but with simple code change the updates done in a deferred update could be disabled altogether, leaving only the Job to be inserted in the JobQueue to do the processing.

Nikerabbit claimed this task.Nov 19 2018, 10:40 AM
Nikerabbit added a project: Language-Team (Language-2018-October-December).

According to Logstash, this warning no longer happens. But there is a new one about writes affecting more than 1000 rows. I will file a new task for that.

Nikerabbit moved this task from Backlog to Done on the Language-Team (Language-2018-October-December) board.Nov 19 2018, 10:41 AM
Pginer-WMF closed this task as Resolved.Nov 27 2018, 8:37 AM
Nikerabbit mentioned this in T134252: Avoid "Lock wait timeout exceeded" from MessageGroupStats::clear.Dec 3 2018, 10:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL