Update Campaigns to use AuthManager
Closed, ResolvedPublic
Actions

Description

Items needing updating are:

Use of the AddNewAccount hook - should use LocalUserCreated instead
Use of the UserCreateForm hook
Use of the UserLoginForm hook

Details

Subject	Repo	Branch	Lines +/-
Restore 'loginCTA' campaign name for the signup link at the bottom of login	mediawiki/extensions/Campaigns	master	+10 -0
Update extension for AuthManager	mediawiki/extensions/Campaigns	REL1_27	+182 -81
Update extension for AuthManager	mediawiki/extensions/Campaigns	master	+182 -81

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• Deskana	T75616 Tracking: API/backend issues blocking Wikipedia app development
Resolved		Anomie	T32788 Allow triggering of user password reset email via the API
Open		None	T90925 General authentication improvements for MediaWiki
Resolved		Anomie	T48179 Allow a challenge stage during authentication
Open		None	T5709 Refactoring to make external authentication and identity systems easier
Resolved		Tgr	T43201 UserLoadFromSession considered evil
Resolved		Anomie	T67493 Session is started by EditAction (problem for extensions using UserLoadFromSession hook)
Open	Feature	None	T55156 Provide option to force a login session to end within a certain time
Open		None	T89459 Modernize MediaWiki authentication system (AuthManager)
Open		None	T110291 Update all extensions to use AuthManager
Resolved		• demon	T135498 Release AuthManager with MediaWiki 1.27
Resolved		Tgr	T138910 Backport AuthManager-related changes to 1.27
Resolved		None	T130340 [Reading Infrastructure 2015-16 Q4] Enable two-factor authentication via AuthManager on the Wikimedia cluster
Resolved		• Mattflaschen-WMF	T68699 Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis
Resolved		Tgr	T135504 Enable AuthManager in WMF production
Resolved		Anomie	T110282 Update extensions which are deployed on the Wikimedia cluster to use AuthManager
Resolved		• demon	T135043 Update Campaigns to use AuthManager

Event Timeline

Anomie created this task.May 11 2016, 8:21 PM

Restricted Application added a subscriber: Zppix. · View Herald TranscriptMay 11 2016, 8:21 PM

Looking at the extension a bit closer, you'd probably want to do something like https://gerrit.wikimedia.org/r/#/c/290715/ to replace the AddNewAccount and UserCreateForm hooks. But the existing code is confusingly complex for such a small extension (e.g. it sets a JS config var and loads an RL module just to set a cookie), which makes me wonder whether it's that way for a good reason or if it's just overcomplicated.

I don't know what you might do for the UserLoginForm hook, it might need adding a new hook to LoginSignupSpecialPage to get at the link (or else horrible messing with HTML in the 'BeforePageDisplay' hook).

Change 291280 had a related patch set uploaded (by Anomie):
Update extension for AuthManager

https://gerrit.wikimedia.org/r/291280

gerritbot added a project: Patch-For-Review.May 27 2016, 5:24 PM

Anomie moved this task from Backlog to Needs Review/Feedback on the Reading-Infrastructure-Team-Old (Don't use) board.May 27 2016, 5:25 PM

• demon raised the priority of this task from Medium to High.May 31 2016, 4:14 PM

Change 291280 merged by jenkins-bot:
Update extension for AuthManager

https://gerrit.wikimedia.org/r/291280

• demon closed this task as Resolved.May 31 2016, 5:09 PM

• demon claimed this task.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Jun 1 2016, 3:01 AM

Liuxinyu970226 unsubscribed.Jun 3 2016, 9:06 AM

Change 296506 had a related patch set uploaded (by Gergő Tisza):
Update extension for AuthManager