Page MenuHomePhabricator

Update Campaigns to use AuthManager
Closed, ResolvedPublic

Description

Items needing updating are:

  • Use of the AddNewAccount hook - should use LocalUserCreated instead
  • Use of the UserCreateForm hook
  • Use of the UserLoginForm hook

Event Timeline

Anomie created this task.May 11 2016, 8:21 PM
Restricted Application added a subscriber: Zppix. · View Herald TranscriptMay 11 2016, 8:21 PM

Looking at the extension a bit closer, you'd probably want to do something like https://gerrit.wikimedia.org/r/#/c/290715/ to replace the AddNewAccount and UserCreateForm hooks. But the existing code is confusingly complex for such a small extension (e.g. it sets a JS config var and loads an RL module just to set a cookie), which makes me wonder whether it's that way for a good reason or if it's just overcomplicated.

I don't know what you might do for the UserLoginForm hook, it might need adding a new hook to LoginSignupSpecialPage to get at the link (or else horrible messing with HTML in the 'BeforePageDisplay' hook).

Change 291280 had a related patch set uploaded (by Anomie):
Update extension for AuthManager

https://gerrit.wikimedia.org/r/291280

demon raised the priority of this task from Normal to High.May 31 2016, 4:14 PM

Change 291280 merged by jenkins-bot:
Update extension for AuthManager

https://gerrit.wikimedia.org/r/291280

demon closed this task as Resolved.May 31 2016, 5:09 PM
demon claimed this task.

Change 296506 had a related patch set uploaded (by Gergő Tisza):
Update extension for AuthManager

https://gerrit.wikimedia.org/r/296506

Change 296506 merged by jenkins-bot:
Update extension for AuthManager

https://gerrit.wikimedia.org/r/296506

Change 302478 had a related patch set uploaded (by Gergő Tisza):
Restore 'loginCTA' campaign name for the signup link at the bottom of login

https://gerrit.wikimedia.org/r/302478

Change 302478 merged by jenkins-bot:
Restore 'loginCTA' campaign name for the signup link at the bottom of login

https://gerrit.wikimedia.org/r/302478