Remove special handling for page protection in MW API results
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• Mholloway
	May 11 2016, 9:55 PM

Description

After the fix for T69054 is rolled out next week as part of 1.28.0-wmf.2, the following special handling will no longer be needed and should be removed:

(app) the custom Protection deserializer in MwPageLead;
(mcs) the sanitizeEmptyProtection function in mobile-sections.js.

Details

	Subject	Repo	Branch	Lines +/-
	Hygiene: remove protection unmarshaller	apps/android/wikipedia	master	+20 -130
	Remove sanitizeEmptyProtection	mediawiki/services/mobileapps	master	+1 -8

Customize query in gerrit

Related Objects

Mentioned Here: T69054: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output

Event Timeline

• Mholloway created this task.May 11 2016, 9:55 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 11 2016, 9:55 PM

• Mholloway renamed this task from Remove custom Protection deserializer from MwPageLead to Remove special handling for page protection in MW API results.May 11 2016, 10:00 PM

• Mholloway added a project: Mobile-Content-Service.

• Mholloway updated the task description. (Show Details)

Dbrant moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.May 13 2016, 9:13 PM

Change 289682 had a related patch set uploaded (by Niedzielski):
Hygiene: remove protection unmarshaller

https://gerrit.wikimedia.org/r/289682

gerritbot added a project: Patch-For-Review.May 19 2016, 9:19 PM

Change 289771 had a related patch set uploaded (by Mholloway):
Remove sanitizeEmptyProtection

https://gerrit.wikimedia.org/r/289771

Change 289771 merged by jenkins-bot:
Remove sanitizeEmptyProtection

https://gerrit.wikimedia.org/r/289771

Zuul is working at its own pace today but Stephen's patch is on its way to being merged so I'm calling this resolved.

• Mholloway closed this task as Resolved.May 20 2016, 9:51 PM

Change 289682 merged by jenkins-bot:
Hygiene: remove protection unmarshaller