Page MenuHomePhabricator
Create Task
Maniphest T135126

Copy/pasting links on Flow has multiple unexpected behaviors
Open, LowestPublic8 Estimated Story Points
Actions

Description

If you copy/paste a pre-existing link on Flow, several cases disturbances can happen. I've identified several of them but they don't work every time.

Copy a link

  1. start or reply to a conversation
  2. copy a link from somewhere
  3. paste: impossible to paste it

If you press space before pasting or if you paste is after typing a text, it sometimes works, but you sometimes only have rough text, without links or a blank space inserted.

Copy an username

  1. start or reply to a conversation
  2. copy the username from the Flow post signature
  3. paste: impossible to paste it (a blank is left)

If you press space before pasting or if you paste is after typing a text, it does not work.

Clear a link
You have managed to paste the link with the source link (congrats!)

  1. click on that link
  2. click on the formatting icon F4000648
  3. it is not working

It works when you create the link (select text, click on "link" icon, choose a page and add it).

Related Objects
Search...

Event Timeline

Trizek-WMF created this task.May 12 2016, 1:09 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 12 2016, 1:09 PM
Trizek-WMF triaged this task as High priority.EditedMay 12 2016, 1:10 PM

Triaged as High: it is a very basic functionality with a big impact.

Catrope subscribed.May 12 2016, 10:50 PM

It looks like the blank space issue may be the following round-trip issue:

  • User pastes link to https://de.wikipedia.org/wiki/Foo
  • Parsoid html2wt (incorrectly) turns this into [[de:Foo]]
  • Parsoid wt2html (correctly) interprets that as a language link and renders nothing

which sounds like a bug in Parsoid

Trizek-WMF added a comment.May 13 2016, 10:05 AM

Should I split that task in sub-tasks?

• Mattflaschen-WMF added a project: VisualEditor.May 16 2016, 9:54 PM
• jmatazzoni moved this task from Untriaged to Near-Term Interest on the Collaboration-Team-Triage board.May 16 2016, 9:55 PM
Catrope added a comment.May 16 2016, 9:55 PM
In T135126#2292045, @Trizek-WMF wrote:

Should I split that task in sub-tasks?

Yes please.

Trizek-WMF created subtask T135620: VE won't recognise <bdi> tags on paste.May 18 2016, 12:45 PM
Trizek-WMF created subtask T135621: Copy/pasting a link to a page (except user page) on Flow sometimes can't be pasted (invalid/blacklisted HTML?).
Trizek-WMF created subtask T135622: Clear links created by copy/pasting on Flow have an unexpected behavior.May 18 2016, 12:49 PM
Esanders subscribed.May 18 2016, 4:09 PM
This comment was removed by Esanders.
Catrope mentioned this in T135621: Copy/pasting a link to a page (except user page) on Flow sometimes can't be pasted (invalid/blacklisted HTML?).May 18 2016, 6:38 PM
Jdforrester-WMF closed subtask T135620: VE won't recognise <bdi> tags on paste as Resolved.May 19 2016, 10:28 AM
Jdforrester-WMF closed subtask T135622: Clear links created by copy/pasting on Flow have an unexpected behavior as Resolved.May 19 2016, 1:33 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.May 24 2016, 7:25 PM
Jdforrester-WMF set the point value for this task to 8.May 31 2016, 6:50 PM
Etonkovidova subscribed.EditedJun 10 2016, 10:31 PM

Checked
Copy a link

  1. Enter the following as wikitext production (tested on frwiki and testwiki). Save.
Internal link: [[Rab]]

Internal link with a name: [[Rab|Rab island]]

External link without a name: [http://www.google.com]

External link with a name: [http://www.google.com Google has the most powerful search engine]
  1. Open another Reply in VE mode and copy from the previously posted text

Nothing will be posted. The error will be displayed.

Uncaught TypeError: Cannot read property 'getType' of undefined
openAnnotation
ve.dm.Converter.static.openAndCloseAnnotations
ve.ce.ContentBranchNode.getRenderedContents
ve.ce.ContentBranchNode.renderContents
ve.ce.ContentBranchNode.onSplice
VeCeBranchNode
VeCeContentBranchNode
VeCeParagraphNode
oo.Factory.create
ve.ce.BranchNode.onSplice
oo.EventEmitter.emit
ve.dm.BranchNode.splice
ve.batchSplice	
ve.dm.Document.rebuildNodes	
ve.dm.DocumentSynchronizer.synchronizers.rebuild	
ve.dm.DocumentSynchronizer.synchronize	
ve.dm.TransactionProcessor.process	
ve.dm.Document.commit	
ve.dm.Surface.changeInternal	
ve.dm.Surface.change
ve.ce.Surface.afterPaste
Etonkovidova added a subtask: T137503: Can't copy/paste external links in VE in Firefox.Jun 11 2016, 1:47 AM
Etonkovidova added a comment.Jun 11 2016, 1:57 AM

Checked Copy a username in testwiki and frwiki - copying all kinds of username links/signatures seems to be fine.

The username links formatted as the samples below can be copied/pasted successfully.

[[User:ET70]] 
[[User:Etonkovidova|<bdi>Etonkovidova</bdi>]] 

@[http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:ET80&action=edit&redlink=1 ET80]
{{FlowMention|Etonkovidova}}
Etonkovidova added a comment.Jun 11 2016, 2:28 AM

Checked Clear a link

It works when you create the link (select text, click on "link" icon, choose a page and add it).

Seems that it was something special in the format of the link. In regular cases - when the link is formatted e.g. [[Amyannan umsqedac:Issimo 15|Amyannan umsqedac:Issimo 15]] - all options in Edit link are working.

The only interesting thing is - if I copy non-existing link to another reply, e.g. the link which is

<a href="/w/index.php?title=Amyannan_umsqedac:Issimo_15&amp;action=edit&amp;redlink=1" class="new" title="Amyannan umsqedac: Issimo 15" rel="mw:WikiLink" data-parsoid="{&quot;stx&quot;:&quot;piped&quot;,&quot;a&quot;:{&quot;href&quot;:&quot;./Amyannan_umsqedac:Issimo_15&quot;},&quot;sa&quot;:{&quot;href&quot;:&quot;Amyannan umsqedac:Issimo 15&quot;},&quot;dsr&quot;:[0,60,30,2]}"><font><font>Amyannan umsqedac: Issimo 15</font></font></a>

the non-exisiting link gets displayed as an existing link:

<a rel="mw:ExtLink" href="https://fr.wikipedia.org/w/index.php?title=Amyannan_umsqedac:Issimo_15&amp;action=edit&amp;redlink=1" data-parsoid="{&quot;targetOff&quot;:156,&quot;contentOffsets&quot;:[156,184],&quot;dsr&quot;:[62,185,94,1]}" class="external"><font><font class="">Amyannan umsqedac: Issimo 15</font></font></a>

And a user sees it as

Screen Shot 2016-06-10 at 7.14.03 PM.png (168×746 px, 26 KB)

Jdforrester-WMF closed subtask T137503: Can't copy/paste external links in VE in Firefox as Resolved.Jun 28 2016, 4:33 PM
• Deskana lowered the priority of this task from High to Lowest.Aug 30 2018, 10:10 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 30 2018, 10:10 AM
• Deskana moved this task from TR0: Interrupt to Freezer on the VisualEditor board.Aug 30 2018, 10:10 AM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 7:00 PM
Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL