Page MenuHomePhabricator
Create Task
Maniphest T135147

Make the domain model implemented by Site/SiteLookup/SiteStore more flexible
Open, MediumPublic
Actions

Description

As per T113034, the domain model (aka data structure) of a Site object should be able to represent the structure outlined in P3044. In particular, it should allow for:

  • multiple ids (of multiple kinds): getIds( $kind ): string[]
  • multiple groups (of multiple kinds): getGroups( $kind ): string[] and inGroup( $kind, $group ): bool; The old getGroup() method should be deprecated. getGlobalId() should return the canonical global id.
  • arbitrary properties and paths (already supported, but should be revised)

Similarly, the SiteLookup should support lookup by various ids and groups:

  • getSiteById( $kind, $id ): Site
  • listGroup( $kind, $group ): string[]

Structure outline, for reference:

P3044 interwiki.json
1{
2 "enwiki": {
3 "type": "mediawiki",
4 "ids": {
5 "global": [ "enwiki", "some-old-alias" ],
6 "interwiki": "en",
7 "domain": "en.wikipedia.org"
8 },
9 "groups": {
10 "language": "en",
11 "size": "big",
12 "family": "wikipedia",
13 "db-cluster": "s1"
14 },
15 "paths": {
16 "article": "//en.wikipedia.org/wiki/$1",
17 "api": "https://en.wikipedia.org/w/api.php"
18 },
19 "props": {
20 "database": "enwiki",
21 "language": "en"
22 }
23 },
24 "enwiktionary": {
25 "type": "mediawiki",
26 "ids": {
27 "global": "enwiktionary",
28 "interwiki": [ "wiktionary", "wikt" ],
29 "domain": "en.wiktionary.org"
30 },
31 "groups": {
32 "language": "en",
33 "family": "wiktionary",
34 "db-cluster": "s2"
35 },
36 "paths": {
37 "article": "//en.wiktionary.org/wiki/$1",
38 "api": "https://en.wiktionary.org/w/api.php"
39 },
40 "props": {
41 "database": "enwiktionary",
42 "language": "en",
43 "capital-links": false
44 }
45 },
46 "commonswiki": {
47 "type": "mediawiki",
48 "ids": {
49 "global": [ "commonswiki", "commons" ],
50 "interwiki": [ "commons", "c" ],
51 "domain": "commons.wikimedia.org"
52 },
53 "groups": {
54 "language": "en",
55 "family": "commons",
56 "db-cluster": "s2"
57 },
58 "paths": {
59 "article": "//commons.wikimedia.org/wiki/$1",
60 "api": "https://commons.wikimedia.org/w/api.php"
61 },
62 "props": {
63 "database": "commonswiki",
64 "multilingual": true,
65 "transcludable": true
66 }
67 },
68 "bb": {
69 "type": "unknown",
70 "ids": {
71 "global": ["bb", "boingboing" ],
72 "interwiki": "bb",
73 "domain": "boingboing.net"
74 },
75 "groups": {
76 "language": "en"
77 },
78 "paths": {
79 "article": "https://boingboing.net/$1.html"
80 },
81 "props": {
82 "language": "en"
83 }
84 },
85 "_by_ids": {
86 "global": {
87 "some-old-alias": "enwiki",
88 "enwiki": "enwiki",
89 "enwiktionary": "enwiktionary",
90 "commonswiki": "commonswiki",
91 "commons": "commonswiki",
92 "bb": "bb",
93 "boingboing": "bb"
94 },
95 "interwiki": {
96 "en": "enwiki",
97 "wiktionary": "enwiktionary",
98 "wikt": "enwiktionary",
99 "c": "commonswiki",
100 "commons": "commonswiki",
101 "bb": "bb"
102 },
103 "domain": {
104 "en.wikipedia.org": "enwiki",
105 "en.wiktionary.org": "enwiktionary",
106 "commons.wikimedia.org": "commonswiki",
107 "boingboing.net": "bb"
108 }
109 },
110 "_by_groups": {
111 "language": {
112 "en": [ "enwiki", "enwiktionary", "bb" ],
113 "mul": [ "commonswiki" ]
114 },
115 "family": {
116 "wikipedia": [ "enwiki" ],
117 "wiktionary": [ "enwiktionary" ],
118 "commons": [ "commonswiki" ]
119 },
120 "db-cluster": {
121 "s1": [ "enwiki" ],
122 "s2": [ "enwiktionary", "commonswiki" ]
123 }
124 }
125}

Related Objects
Search...

Event Timeline

daniel created this task.May 12 2016, 4:50 PM
daniel renamed this task from Make the domain model for Site/SiteLookup/SiteStore more flexible to Make the domain model implemented by Site/SiteLookup/SiteStore more flexible.May 12 2016, 4:54 PM
daniel mentioned this in T135149: Implement a SiteLookup based on a nested array structure..May 12 2016, 4:57 PM
daniel removed a parent task: T135146: Create an adapter that implements InterwikiLookup on top of SiteLookup.
daniel added a parent task: T113034: RFC: Overhaul Interwiki map, unify with Sites and WikiMap.
daniel created subtask T135153: Allow Sites and Interwiki facilities to be configured consistently.May 12 2016, 5:27 PM
daniel removed a subtask: T135153: Allow Sites and Interwiki facilities to be configured consistently.
daniel added a parent task: T135146: Create an adapter that implements InterwikiLookup on top of SiteLookup.May 12 2016, 6:05 PM
daniel added a project: Wikidata-Sprint-2016-05-24.
Quiddity unsubscribed.May 12 2016, 10:03 PM
Lydia_Pintscher moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-05-24 board.May 24 2016, 1:03 PM
daniel added a project: WMDE-TLA-Team.Sep 19 2016, 1:58 PM
daniel removed daniel as the assignee of this task.Sep 19 2016, 2:00 PM
WMDE-leszek subscribed.Sep 20 2016, 8:36 AM
daniel claimed this task.Oct 31 2016, 4:22 PM
daniel added a project: Wikidata.
daniel moved this task from proposed to accepted on the WMDE-TLA-Team board.Nov 1 2016, 1:43 PM
Ladsgroup edited projects, added Wikidata-Former-Sprint-Board; removed WMDE-TLA-Team.Nov 18 2016, 10:55 AM
Ladsgroup moved this task from Proposed to Backlog on the Wikidata-Former-Sprint-Board board.Nov 18 2016, 10:56 AM
WMDE-leszek moved this task from Backlog to Proposed on the Wikidata-Former-Sprint-Board board.Dec 6 2016, 2:47 PM
daniel added a project: User-Daniel.Dec 6 2016, 6:11 PM
daniel moved this task from Inbox to Push on the User-Daniel board.Jan 5 2017, 7:01 PM
daniel moved this task from Push to To Do on the User-Daniel board.
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.May 5 2017, 12:54 PM
Lydia_Pintscher removed a project: Wikidata-Former-Sprint-Board.Nov 21 2017, 8:59 AM
TheDJ added a parent task: T7501: Expand prefix of interproject link when showing the link in the tooltip.Apr 4 2018, 12:36 PM
Aklapper removed daniel as the assignee of this task.Jun 19 2020, 4:23 PM

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)

Winston_Sung moved this task from Backlog to General on the MediaWiki-Site-system board.Feb 2 2024, 4:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL