Page MenuHomePhabricator

[Bug] Revisions of bytes added/removed count 0 are not represented correctly in the chart
Closed, ResolvedPublic2 Estimated Story Points

Description

Currently height of revision bars is based on number of bytes added/removed in the particular review. That of course makes sense.
When the revision does not change the size of the page in bytes (e.g. it fixes typo like "diary" vs "dairy") height of the bar counted that way should be set to 0. Thanks to the border of the bar, such a bar of height 0 would still be visible and hoverable.

What I noticed is instead of having no height bars related to revisions considered here are higher, and pointing "downwards".
Please see the screenshot attached (forgive my drawing skills). Bars of size 0 seem clearly "bigger" than "-1" or "1".

revslider-diffsize0.png (289×598 px, 11 KB)

Another question remains how such revisions should be presented in the chart. The border of zero-height bar would be visible but hovering it to see e.g. a summary is rather far from easy.

Event Timeline

WMDE-leszek set the point value for this task to 2.May 13 2016, 10:50 AM
WMDE-leszek moved this task from Proposed to Doing on the TCB-Team-Sprint-2016-05-04 board.

Change 288627 had a related patch set uploaded (by WMDE-leszek):
Fix height of bars for revisions that haven't changed the page size

https://gerrit.wikimedia.org/r/288627

Merged the patch as it fixes the oddness.
But I think we should still come up with a better way of displaying 0 sized edits!

Change 288627 merged by jenkins-bot:
Fix height of bars for revisions that haven't changed the page size

https://gerrit.wikimedia.org/r/288627