Page MenuHomePhabricator
Create Task
Maniphest T135257

findHooks.php is broken due to short array syntax
Closed, ResolvedPublic
Actions

Description

The regex in findHooks.php expects array( ... ), and not short array syntax.

Details

SubjectRepoBranchLines +/-
Support short array syntax in findHooks.phpmediawiki/coreREL1_27+3 -3
Support short array syntax in findHooks.phpmediawiki/coremaster+3 -3
Customize query in gerrit

Event Timeline

Legoktm created this task.May 13 2016, 6:53 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 13 2016, 6:53 PM
• demon subscribed.Jun 10 2016, 4:30 PM

Regular expressions in PHP are a pain. Can't we just use the tokenizer?

gerritbot subscribed.Jun 10 2016, 8:28 PM

Change 293874 had a related patch set uploaded (by Chad):
Support short array syntax in findHooks.php

https://gerrit.wikimedia.org/r/293874

gerritbot added a project: Patch-For-Review.Jun 10 2016, 8:28 PM
gerritbot added a comment.Jun 13 2016, 9:53 PM

Change 294180 had a related patch set uploaded (by Chad):
Support short array syntax in findHooks.php

https://gerrit.wikimedia.org/r/294180

gerritbot added a comment.Jun 13 2016, 9:59 PM

Change 293874 merged by jenkins-bot:
Support short array syntax in findHooks.php

https://gerrit.wikimedia.org/r/293874

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)), MW-1.28-release-notes.Jun 13 2016, 10:00 PM
Jdforrester-WMF closed this task as Resolved.Jun 13 2016, 10:00 PM
Jdforrester-WMF assigned this task to • demon.
Jdforrester-WMF triaged this task as Medium priority.
gerritbot added a comment.Jun 13 2016, 10:05 PM

Change 294180 merged by jenkins-bot:
Support short array syntax in findHooks.php

https://gerrit.wikimedia.org/r/294180

ReleaseTaggerBot added a project: MW-1.27-release-notes.Jun 13 2016, 11:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL