Page MenuHomePhabricator

Update LanguageSelector for AuthManager
Closed, ResolvedPublic

Description

The AddNewAccount hook has been replaced by LocalUserCreated since 1.26. The AddNewAccount hook will no longer be reliably called under AuthManager.

A few extensions still use this hook, see here: https://codesearch.wmflabs.org/extensions/?q=AddNewAccount&i=nope&files=&repos= and LanguageSelector is one of them for sure!

Event Timeline

Change 491458 had a related patch set uploaded (by Mahveotm; owner: Mahveotm):
[mediawiki/extensions/LanguageSelector@master] Replaced outdated 'AddNewAccount' hook with 'LocalUserCreated' hook in LanguageSelector.php

https://gerrit.wikimedia.org/r/491458

Change 680694 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/extensions/LanguageSelector@master] [LanguageSelector] Cleanup deprecated hooks and convert to ExtensionRegistry

https://gerrit.wikimedia.org/r/680694

Change 681162 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/extensions/LanguageSelector@REL1_36] [LanguageSelector] Cleanup deprecated hooks and convert to ExtensionRegistry

https://gerrit.wikimedia.org/r/681162

Change 680694 merged by jenkins-bot:

[mediawiki/extensions/LanguageSelector@master] [LanguageSelector] Cleanup deprecated hooks and convert to ExtensionRegistry

https://gerrit.wikimedia.org/r/680694

Change 681162 merged by jenkins-bot:

[mediawiki/extensions/LanguageSelector@REL1_36] [LanguageSelector] Cleanup deprecated hooks and convert to ExtensionRegistry

https://gerrit.wikimedia.org/r/681162

Change 491458 abandoned by Jack Phoenix:

[mediawiki/extensions/LanguageSelector@master] Replaced outdated 'AddNewAccount' hook with 'LocalUserCreated' hook in LanguageSelector.php

Reason:

Obsolete patch, a similar one was already merged

https://gerrit.wikimedia.org/r/491458