Page MenuHomePhabricator
Create Task
Maniphest T135297

Fix Heading typeface and padding
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
• Mholloway
Authored By
• Nirzar
May 14 2016, 1:09 AM
Tags
Referenced Files
F4008267: Artboard 1.png
May 14 2016, 1:09 AM
F4008266: Artboard 1 Copy.png
May 14 2016, 1:09 AM
F4008268: Artboard 1 Copy 2.png
May 14 2016, 1:09 AM
Subscribers
Aklapper
Dbrant
gerritbot
• Nirzar
Zppix

Description

The problem
H3 and onward heading on android app use Serif fonts.

The change
They should Sans-serif typeface. also the alignment is off.

Note: We fixed this on iOS app.

Platform agnostic spec

Artboard 1 Copy.png (1×3 px, 409 KB)

Artboard 1.png (1×3 px, 542 KB)

Artboard 1 Copy 2.png (1×3 px, 574 KB)

This is the exact diff change in the css we implemented on iOS

Details

SubjectRepoBranchLines +/-
Add special header stylesapps/android/wikipediamaster+36 -0
Add special header stylesmediawiki/extensions/MobileAppmaster+24 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 InvalidNoneT135293 Improve in-article experience
 Resolved• MhollowayT135297 Fix Heading typeface and padding

Event Timeline

• Nirzar renamed this task from Fix H3+ to Fix Heading typeface and padding.May 14 2016, 1:09 AM
• Nirzar created this task.
• Nirzar updated the task description. (Show Details)
• Niedzielski set the point value for this task to 1.May 25 2016, 7:42 PM
Dbrant moved this task from Needs Triage to Product Backlog on the Wikipedia-Android-App-Backlog board.May 25 2016, 7:49 PM
MBinder_WMF added a project: Android-app-feature-Navigation.Jun 30 2016, 5:37 PM
MBinder_WMF added a project: Duplicate project.Jun 30 2016, 5:53 PM
MBinder_WMF edited projects, added Android-app-feature-Navigation (2016-Q1-Jul-Oct-MVP); removed Android-app-feature-Navigation.Jul 7 2016, 6:19 PM
MBinder_WMF added a project: Mobile-App-Android-Sprint-87-Francium.Jul 7 2016, 10:23 PM
Dbrant removed Dbrant as the assignee of this task.Jul 21 2016, 10:17 PM
Dbrant subscribed.
MBinder_WMF edited projects, added Mobile-App-Android-Sprint-88-Radium; removed Mobile-App-Android-Sprint-87-Francium.Jul 22 2016, 6:30 PM
• Mholloway claimed this task.Aug 15 2016, 6:50 AM
• Mholloway moved this task from To Do to Doing on the Mobile-App-Android-Sprint-88-Radium board.
gerritbot subscribed.Aug 15 2016, 10:25 AM

Change 304801 had a related patch set uploaded (by Mholloway):
Add special header styles

https://gerrit.wikimedia.org/r/304801

gerritbot added a project: Patch-For-Review.Aug 15 2016, 10:25 AM
gerritbot added a comment.Aug 15 2016, 10:31 AM

Change 304803 had a related patch set uploaded (by Mholloway):
Add special header styles

https://gerrit.wikimedia.org/r/304803

• Mholloway added a comment.Aug 15 2016, 10:35 AM

I don't see the below-h2 divider in the iOS app. Is that new?

• Nirzar added a comment.Aug 15 2016, 5:06 PM

I don't see the below-h2 divider in the iOS app. Is that new?

Below h2 divider?

• Mholloway added a comment.Aug 15 2016, 5:10 PM

Yep, the second screenshot calls for a "very light separator for anchoring the pencil and general separation between H3 and content."

• Nirzar added a comment.Aug 15 2016, 5:12 PM

@Mholloway oh my bad. we did not actually do it. it was proposed in the first draft. ignore it for now. good catch.

• Mholloway added a comment.Aug 15 2016, 5:28 PM

Cool, thanks @Nirzar, I'll move this over to Code Review then.

• Mholloway moved this task from Doing to Code Review on the Mobile-App-Android-Sprint-88-Radium board.Aug 15 2016, 5:28 PM
Dbrant added a project: Mobile-App-Android-Sprint-89-Actinium.Aug 15 2016, 6:32 PM
Dbrant moved this task from To Do to Code Review on the Mobile-App-Android-Sprint-89-Actinium board.Aug 15 2016, 6:33 PM
Dbrant added a project: Mobile-App-Android-Sprint-90-Thorium.Aug 29 2016, 4:19 PM
Dbrant moved this task from To Do to Code Review on the Mobile-App-Android-Sprint-90-Thorium board.Aug 29 2016, 4:19 PM
gerritbot added a comment.Sep 7 2016, 9:09 PM

Change 304801 merged by jenkins-bot:
Add special header styles

https://gerrit.wikimedia.org/r/304801

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Sep 7 2016, 10:00 PM
Dbrant moved this task from Code Review to Design Signoff on the Mobile-App-Android-Sprint-90-Thorium board.Sep 7 2016, 10:51 PM
gerritbot added a comment.Sep 8 2016, 12:43 PM

Change 304803 merged by jenkins-bot:
Add special header styles

https://gerrit.wikimedia.org/r/304803

• Nirzar added a comment.Sep 9 2016, 6:19 PM

This looks great. thanks! the headers are fixed

• Nirzar moved this task from Design Signoff to QA Signoff on the Mobile-App-Android-Sprint-90-Thorium board.Sep 9 2016, 6:20 PM
Dbrant moved this task from QA Signoff to Done on the Mobile-App-Android-Sprint-90-Thorium board.Sep 12 2016, 3:14 PM
Dbrant closed this task as Resolved.Sep 12 2016, 3:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL