Page MenuHomePhabricator

Verify correctness of $data field handling
Closed, ResolvedPublic3 Story Points


The Donation and MembershipApplication Doctrine Repositories both write and read from their respective $data field. While this code is tested, the tests might be wrong as well. This can easily happen when the person implementing misunderstood what a field inside $data should contain.

Automated tests against real data would be nice. Perhaps some real db records (export) that a test can create, then read into the domain and save back, and assert nothing changed?