Page MenuHomePhabricator
Create Task
Maniphest T135378

The SidebarTranslate gadget is broken when used with Compact Language Links
Closed, ResolvedPublic
Actions

Description

The SidebarTranslate gadget is broken when used with Compact Language Links.

A JS error is shown: Cannot read property 'toLowerCase' of null TypeError: Cannot read property 'toLowerCase' of null

This happens because the gadget adds more <a> elements, and when the ULS code is trying to process all the <a> elements, it fails when it doesn't find an element with a lang attribute.

Several possible solutions:

  • Add a particular class to the <a> element of the actual interlanguage link, so that ULS would only load that element. This will have to be in core MediaWiki.
  • When querying for elements, use this.$interlanguageList.find( 'li.interlanguage-link > a:first-child' ) instead of just this.$interlanguageList.find( 'li.interlanguage-link > a' ). This should solve the problem with this gadget, but may break with other gadgets that add <a> elements.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Query only for <a> elements that are interlanguage links targetsAmire80mediawiki/extensions/UniversalLanguageSelectormaster+18 -3
Query for <a> elements with first-childAmire80mediawiki/extensions/UniversalLanguageSelectormaster+4 -2
Customize query in gerrit

Event Timeline

Amire80 created this task.May 16 2016, 12:19 PM
Restricted Application added a project: UniversalLanguageSelector. · View Herald TranscriptMay 16 2016, 12:19 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript
Amire80 triaged this task as High priority.May 16 2016, 12:22 PM
Amire80 moved this task from Backlog to Gargets and local customization on the ULS-CompactLinks board.
Amire80 moved this task from Gargets and local customization to Other on the ULS-CompactLinks board.May 25 2016, 9:12 PM
Amire80 renamed this task from The SidebarTranslate gadget overrides Compact Language Links to The SidebarTranslate gadget is broken when used with Compact Language Links.Sep 10 2016, 1:46 PM
Amire80 updated the task description. (Show Details)
gerritbot subscribed.Sep 10 2016, 2:08 PM

Change 309733 had a related patch set uploaded (by Amire80):
Query only for <a> elements that are interlanguage links targets

https://gerrit.wikimedia.org/r/309733

gerritbot added a project: Patch-For-Review.Sep 10 2016, 2:08 PM
gerritbot added a comment.Sep 10 2016, 2:17 PM

Change 309734 had a related patch set uploaded (by Amire80):
Query for <a> elements with first-child

https://gerrit.wikimedia.org/r/309734

Amire80 added a comment.Sep 10 2016, 2:20 PM

I committed patches for both suggestions. Only one should be merged.

https://gerrit.wikimedia.org/r/309733 is the one I prefer because it's more robust and the core change can be useful for other purposes, but if that core change is not desirable, then https://gerrit.wikimedia.org/r/309734 should work.

Yet another solution would be fix the particular gadget, of course, but other gadgets can cause similar breakage, so a solution inside the extension code should be more comprehensive.

Amire80 added a comment.Sep 11 2016, 9:56 AM

See some more information at https://en.wikipedia.org/wiki/MediaWiki_talk:Gadget-SidebarTranslate.js .

By applying the suggestions on that page, the bug will be fully resolved, although in a hacky way. Reviewing and merging the Gerrit patches mentioned above would be more robust, but both things should be done anyway.

Thanks.

Amire80 added a comment.Sep 14 2016, 9:17 AM

After waiting for a few days, I went bold and applied the changes in the English Wikipedia. If anything breaks, blame me :)

I'll still be happy for a review of the patches for core and ULS.

• Elitre subscribed.Sep 14 2016, 11:56 AM
gerritbot added a comment.Oct 3 2016, 9:48 AM

Change 309734 abandoned by Amire80:
Query for <a> elements with first-child

Reason:
Not needed now that I06c809 is merged.

https://gerrit.wikimedia.org/r/309734

Amire80 lowered the priority of this task from High to Low.Oct 3 2016, 9:51 AM

Changing priority to Low. The current version of the gadget is already functional along with Compact Language Links. The remaining fixes will be useful in general, but not essential for this particular bug.

gerritbot added a comment.Nov 1 2016, 1:54 PM

Change 309733 merged by jenkins-bot:
Query only for <a> elements that are interlanguage links targets

https://gerrit.wikimedia.org/r/309733

Nikerabbit edited projects, added: Language-Q2-2016-17 Sprint 2; removed: Patch-For-Review.Nov 1 2016, 2:53 PM
Restricted Application added a project: Language-Engineering October-December 2016. · View Herald TranscriptNov 1 2016, 2:53 PM
Nikerabbit moved this task from Backlog to QA on the Language-Q2-2016-17 Sprint 2 board.Nov 1 2016, 2:53 PM
• Arrbee moved this task from Backlog to ULS-maintenance on the Language-Engineering October-December 2016 board.Nov 2 2016, 1:24 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 2 2016, 7:00 PM
Amire80 closed this task as Resolved.Nov 7 2016, 9:49 AM
Amire80 claimed this task.

All the patches are merged and deployed and the gadget works. Thanks for the help.

Amire80 moved this task from QA to Done on the Language-Q2-2016-17 Sprint 2 board.Nov 7 2016, 9:49 AM
Amire80 moved this task from Backlog to Compact Language Links on the UniversalLanguageSelector board.Nov 3 2017, 8:20 AM
Amire80 moved this task from Compact Language Links to Appearance and design on the UniversalLanguageSelector board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits