| • Elitre | |
| May 16 2016, 2:15 PM |
| F4024727: Screen Shot 2016-05-17 at 8.29.24 PM.png | |
| May 17 2016, 7:38 PM |
On any Wikipedia (including SET when "show both editor tabs" is the chosen editing preference), any browser AFAICT (I'm reproducing in Win8):
Console says "Uncaught TypeError: Cannot read property '0' of undefined".
Reported by editors at ja.wiki.
I tried to reproduce this, but the above mentioned steps are not producing the bug. But I have found another set of steps to reproduce the same error:
Observed Result:
Progress bar stops before it completes, VE does not load. Error in the console:
Uncaught TypeError: Cannot read property '0' of undefined
The original steps worked for me. It seems that we actually start the target loading process twice (causing the loading progress counter to be incremented too much and go into undefined indexes of progressSteps), because onEditSectionLinkClick gets called multiple times - so something is setting that function up as handler again when we close VE (or when we reopen it).
Looks like it may be this, in DAT.init.js:
deactivate: function () { if ( userPrefPreferShow && ( !conf.singleEditTab || tabPreference === 'multi-tab' ) ) { init.setupSectionLinks(); } }
This setupSectionLinks call used to run on *save* because we replace the page contents, and therefore click handlers need to be set up again. https://gerrit.wikimedia.org/r/#/c/283591/ changed it to run on any deactivation like this. Of course, in this case, the code is getting run without any save and therefore we don't need to set up the click handlers again.
Change 296496 had a related patch set uploaded (by Alex Monk):
Replace section edit click handlers in DAT instead of doing it badly in init
Change 296496 merged by jenkins-bot:
Replace section edit click handlers in DAT instead of doing it badly in init