Page MenuHomePhabricator
Create Task
Maniphest T135446

Unsubstituted message footer in mail notification of thanks
Closed, ResolvedPublic
Actions

Description

I received a notification of thanks on the Italian Wikisource:

From: Wikisource <wiki@wikimedia.org>
Subject: Alex brollo dankt dir für deine Bearbeitung auf Wikisource
To: "Tim.landscheidt" <tim@tim-landscheidt.de>
Date: Mon, 16 May 2016 08:51:15 +0200 (13 hours, 59 minutes ago)
Reply-To: No Reply <wiki@wikimedia.org>

Alex brollo dankt dir für deine Bearbeitung auf „Utente:Alex brollo“.

Bearbeitung ansehen: <https://it.wikisource.org/w/index.php?title=Utente:Alex_brollo&oldid=prev&diff=1735096>

<echo-email-footer-default>

The last line looks wrong to me.

My UI language set on it.wikisource.org is "de - Deutsch".

Details

SubjectRepoBranchLines +/-
Remove EchoBundleEmailIntervaloperations/mediawiki-configmaster+0 -15
Followup to I95dc3d70c8: Get rid of job queue entry for email bundlingmediawiki/extensions/Echomaster+0 -1
Get rid of email bundlingmediawiki/extensions/Echomaster+16 -367
Bring back messages used by old email formatter systemmediawiki/extensions/Echowmf/1.28.0-wmf.1+3 -1
Bring back messages used by old email formatter systemmediawiki/extensions/Echowmf/1.28.0-wmf.2+6 -2
Bring back messages used by old email formatter systemmediawiki/extensions/Echomaster+6 -2
Attempt to fix unsubstituted message in Echo emailsmediawiki/extensions/Echomaster+2 -2
Attempt to fix unsubstituted message in Echo emailsmediawiki/extensions/Echowmf/1.28.0-wmf.1+1 -1
Customize query in gerrit

Related Objects

Event Timeline

scfc created this task.May 16 2016, 8:57 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 16 2016, 8:57 PM
scfc removed a project: All-and-every-Wikisource.May 16 2016, 8:58 PM
Quiddity added a project: I18n.May 16 2016, 9:24 PM
Quiddity subscribed.
Catrope triaged this task as Unbreak Now! priority.May 16 2016, 9:40 PM
Catrope added a project: Collab-Team-2016-Apr-Jun-Q4.
Catrope added a subscriber: SBisson.
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 16 2016, 9:40 PM
Catrope moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.May 16 2016, 9:40 PM
Catrope assigned this task to SBisson.May 16 2016, 9:51 PM
Catrope subscribed.

Almost certainly a regression from the plaintext email formatter change.

gerritbot subscribed.May 16 2016, 10:05 PM

Change 289091 had a related patch set uploaded (by Catrope):
Attempt to fix unsubstituted message in Echo emails

https://gerrit.wikimedia.org/r/289091

gerritbot added a project: Patch-For-Review.May 16 2016, 10:05 PM
gerritbot added a comment.May 16 2016, 10:44 PM

Change 289098 had a related patch set uploaded (by Catrope):
Attempt to fix unsubstituted message in Echo emails

https://gerrit.wikimedia.org/r/289098

Catrope claimed this task.May 16 2016, 10:51 PM
gerritbot added a comment.May 16 2016, 11:09 PM

Change 289098 merged by jenkins-bot:
Attempt to fix unsubstituted message in Echo emails

https://gerrit.wikimedia.org/r/289098

gerritbot added a comment.May 16 2016, 11:24 PM

Change 289091 merged by jenkins-bot:
Attempt to fix unsubstituted message in Echo emails

https://gerrit.wikimedia.org/r/289091

Catrope added a comment.May 16 2016, 11:29 PM

After this it's no longer unsubstituted, but it's not much better:

To control which emails we send you, check your preferences:

(note the missing preferences link)

@SBisson: could you shed some light about what's supposed to be going on here? Also, hopefully wmf.2 (which contains the HTML formatter change) will behave better?

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-05-17_(1.28.0-wmf.2)), MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)).May 17 2016, 12:00 AM
jayvdb renamed this task from German mail notification of thanks on Italian Wikisource has unsubstituted message footer to Unsubstituted message footer in mail notification of thanks.May 17 2016, 3:33 AM
TerraCodes removed a project: Patch-For-Review.May 17 2016, 4:07 AM
gerritbot added a comment.May 17 2016, 2:37 PM

Change 289217 had a related patch set uploaded (by Sbisson):
Bring back messages used by old email formatter system

https://gerrit.wikimedia.org/r/289217

gerritbot added a project: Patch-For-Review.May 17 2016, 2:37 PM
SBisson added a comment.May 17 2016, 2:44 PM

There's a code path that still uses the old formatter system.

This patch brings back the messages that it depends on: https://gerrit.wikimedia.org/r/#/c/289217/

Next I'm looking at migrating this code path to the new formatter system.

gerritbot added a comment.May 17 2016, 4:36 PM

Change 289217 merged by jenkins-bot:
Bring back messages used by old email formatter system

https://gerrit.wikimedia.org/r/289217

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3)).May 17 2016, 5:00 PM
gerritbot added a comment.May 17 2016, 7:58 PM

Change 289266 had a related patch set uploaded (by Sbisson):
Get rid of email bundling

https://gerrit.wikimedia.org/r/289266

gerritbot added a comment.May 17 2016, 8:01 PM

Change 289268 had a related patch set uploaded (by Catrope):
Bring back messages used by old email formatter system

https://gerrit.wikimedia.org/r/289268

gerritbot added a comment.May 17 2016, 11:55 PM

Change 289268 merged by jenkins-bot:
Bring back messages used by old email formatter system

https://gerrit.wikimedia.org/r/289268

Catrope lowered the priority of this task from Unbreak Now! to Medium.May 18 2016, 12:07 AM

Lowering priority now that the messages have been brought back.

gerritbot added a comment.May 18 2016, 1:14 AM

Change 289346 had a related patch set uploaded (by Catrope):
Bring back messages used by old email formatter system

https://gerrit.wikimedia.org/r/289346

gerritbot added a comment.May 18 2016, 1:22 AM

Change 289346 merged by jenkins-bot:
Bring back messages used by old email formatter system

https://gerrit.wikimedia.org/r/289346

gerritbot added a comment.May 18 2016, 2:23 AM

Change 289266 merged by jenkins-bot:
Get rid of email bundling

https://gerrit.wikimedia.org/r/289266

SBisson moved this task from Ready for Pickup to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.May 18 2016, 12:10 PM
gerritbot added a comment.May 18 2016, 12:17 PM

Change 289395 had a related patch set uploaded (by Sbisson):
Remove EchoBundleEmailInterval

https://gerrit.wikimedia.org/r/289395

Etonkovidova subscribed.May 24 2016, 11:44 PM

Checked the fix in betalabs for multiple replies and linked pages messages and two Preferences- Notifications- Email options 'Individual notifications as they come in' and 'Daily summary of notifications'

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.May 24 2016, 11:44 PM
• jmatazzoni closed this task as Resolved.May 26 2016, 8:00 PM
gerritbot added a comment.Jul 7 2016, 12:31 PM

Change 297780 had a related patch set uploaded (by Sbisson):
Followup to I95dc3d70c8: Get rid of job queue entry for email bundling

https://gerrit.wikimedia.org/r/297780

gerritbot added a comment.Jul 19 2016, 8:38 PM

Change 297780 merged by jenkins-bot:
Followup to I95dc3d70c8: Get rid of job queue entry for email bundling

https://gerrit.wikimedia.org/r/297780

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-26_(1.28.0-wmf.12)).Jul 19 2016, 9:00 PM
gerritbot added a comment.Jul 26 2016, 3:02 PM

Change 289395 merged by jenkins-bot:
Remove EchoBundleEmailInterval

https://gerrit.wikimedia.org/r/289395

Stashbot subscribed.Jul 26 2016, 3:12 PM

Mentioned in SAL [2016-07-26T15:11:58Z] <thcipriani@tin> Synchronized wmf-config/CommonSettings.php: SWAT: [[gerrit:289395|Remove EchoBundleEmailInterval (T135446)]] PART I (duration: 00m 34s)

Stashbot added a comment.Jul 26 2016, 3:12 PM

Mentioned in SAL [2016-07-26T15:12:31Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:289395|Remove EchoBundleEmailInterval (T135446)]] PART II (duration: 00m 26s)

Krinkle mentioned this in T135798: DBPerformance warning for "DELETE .. echo_email_batch" query from MWEchoEmailBatch.Apr 5 2017, 9:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL