Page MenuHomePhabricator
Create Task
Maniphest T135477

Argument 3 passed to SimpleCaptcha::passCaptchaLimited() must be an instance of User, undefined variable given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Beta fluorine has a bunch of errors like this:

May 17 08:25:19 deployment-mediawiki02:  #012Warning: passCaptchaLimited() expects exactly 3 parameters, 0 given in /srv/mediawiki/php-master/extensions/ConfirmEdit/SimpleCaptcha/Captcha.php on line 1093
May 17 08:25:19 deployment-mediawiki02:  #012Catchable fatal error: Argument 3 passed to SimpleCaptcha::passCaptchaLimited() must be an instance of User, undefined variable given in /srv/mediawiki/php-master/extensions/ConfirmEdit/SimpleCaptcha/Captcha.php on line 1093

This is caused by https://gerrit.wikimedia.org/r/#/c/285350/ which adds a bunch of required arguments to SimpleCaptcha::passCaptchaLimited and replaces passCaptchaLimited() calls with passCaptchaLimitedFromRequest($wgRequest, $wgUser). Apparently this method is called from Flow and that has not been updated.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace passCaptcha with passCaptchaFromRequestmediawiki/extensions/ContactPagemaster+4 -4
Replace passCaptcha with passCaptchaFromRequestmediawiki/extensions/ContactPageREL1_27+4 -4
Expose equivalent functionality for passCaptchamediawiki/extensions/ConfirmEditREL1_27+26 -7
Expose equivalent functionality for passCaptchamediawiki/extensions/ConfirmEditmaster+26 -7
Replace passCaptcha with passCaptchaFromRequestmediawiki/extensions/ContactPageFundraisermaster+2 -2
Fix Flow for AuthManager-changes in ConfirmEditmediawiki/extensions/FlowREL1_27+4 -1
Fix Flow for AuthManager-changes in ConfirmEditmediawiki/extensions/Flowmaster+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tgr created this task.May 17 2016, 8:35 AM
Restricted Application added subscribers: Zppix, Florian, Aklapper. · View Herald TranscriptMay 17 2016, 8:35 AM
Tgr added a parent task: T134450: MW-1.28.0-wmf.2 deployment blockers.May 17 2016, 8:35 AM
Florian claimed this task.May 17 2016, 8:57 AM
Florian triaged this task as High priority.
Florian added a project: StructuredDiscussions.
gerritbot subscribed.May 17 2016, 9:02 AM

Change 289155 had a related patch set uploaded (by Florianschmidtwelzow):
Fix Flow for AuthManager-changes in ConfirmEdit

https://gerrit.wikimedia.org/r/289155

gerritbot added a project: Patch-For-Review.May 17 2016, 9:02 AM
gerritbot added a comment.May 17 2016, 9:41 AM

Change 289155 merged by jenkins-bot:
Fix Flow for AuthManager-changes in ConfirmEdit

https://gerrit.wikimedia.org/r/289155

gerritbot added a comment.May 17 2016, 9:51 AM

Change 289159 had a related patch set uploaded (by Gergő Tisza):
Fix Flow for AuthManager-changes in ConfirmEdit

https://gerrit.wikimedia.org/r/289159

Tgr closed this task as Resolved.May 17 2016, 9:51 AM

Tried triggering a captcha in Flow on beta and it worked fine.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-17_(1.28.0-wmf.2)).May 17 2016, 10:00 AM
gerritbot added a comment.May 17 2016, 11:25 AM

Change 289159 merged by jenkins-bot:
Fix Flow for AuthManager-changes in ConfirmEdit

https://gerrit.wikimedia.org/r/289159

Tgr reopened this task as Open.May 17 2016, 4:49 PM

Reopening, this will affect ContactPage / ContactPageFundraiser as well.

Tgr added a comment.May 17 2016, 5:26 PM

testwiki is the only group0 wiki using ContactPage so this is not strictly a blocker for the group0 deploy. In any case I can fix this in an hour or so.

gerritbot added a comment.May 17 2016, 5:57 PM

Change 289250 had a related patch set uploaded (by Gergő Tisza):
Expose equivalent functionality for passCaptcha

https://gerrit.wikimedia.org/r/289250

gerritbot added a comment.May 17 2016, 5:59 PM

Change 289251 had a related patch set uploaded (by Gergő Tisza):
Replace passCaptcha with passCaptchaFromRequest

https://gerrit.wikimedia.org/r/289251

gerritbot added a comment.May 17 2016, 6:40 PM

Change 289251 merged by jenkins-bot:
Replace passCaptcha with passCaptchaFromRequest

https://gerrit.wikimedia.org/r/289251

gerritbot added a comment.May 17 2016, 6:45 PM

Change 289250 merged by jenkins-bot:
Expose equivalent functionality for passCaptcha

https://gerrit.wikimedia.org/r/289250

gerritbot added a comment.May 17 2016, 7:13 PM

Change 289263 had a related patch set uploaded (by Gergő Tisza):
Replace passCaptcha with passCaptchaFromRequest

https://gerrit.wikimedia.org/r/289263

Tgr added a comment.May 17 2016, 7:18 PM

Fixed ContactPage, ContactPageFundraiser is probably not used in production?

Tgr closed this task as Resolved.May 17 2016, 7:18 PM
gerritbot added a comment.May 17 2016, 7:27 PM

Change 289263 merged by jenkins-bot:
Replace passCaptcha with passCaptchaFromRequest

https://gerrit.wikimedia.org/r/289263

• mmodell subscribed.EditedMay 17 2016, 8:36 PM

it looks like https://gerrit.wikimedia.org/r/289263 didn't make the branch cut

does it need to be cherry-picked to wmf.2?

Tgr added a comment.May 17 2016, 8:40 PM

No, it's not used in production. I just got confused by grepping on beta where /extensions includes all Gerrit-hosted extensions.

gerritbot added a comment.May 17 2016, 10:44 PM

Change 289326 had a related patch set uploaded (by Gergő Tisza):
Expose equivalent functionality for passCaptcha

https://gerrit.wikimedia.org/r/289326

gerritbot added a comment.May 17 2016, 10:45 PM

Change 289327 had a related patch set uploaded (by Gergő Tisza):
Replace passCaptcha with passCaptchaFromRequest

https://gerrit.wikimedia.org/r/289327

gerritbot added a comment.May 17 2016, 10:53 PM

Change 289326 merged by jenkins-bot:
Expose equivalent functionality for passCaptcha

https://gerrit.wikimedia.org/r/289326

gerritbot added a comment.May 17 2016, 10:53 PM

Change 289327 merged by jenkins-bot:
Replace passCaptcha with passCaptchaFromRequest

https://gerrit.wikimedia.org/r/289327

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3)).May 24 2016, 11:34 AM
• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jul 20 2016, 1:47 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits