Page MenuHomePhabricator

Formalize how TMH provides a player for Score-generated ogg/vorbis files
Open, LowPublic

Description

Score directly calls the TimedMediaTransformOutput thumbnail generator in order to provide a player for the ogg/vorbis files generated by Score by lilypond.

This isn't really obviously and it's not entirely cleanly setup. We should definitely improved the structure for this kind of usage.

Event Timeline

This might also be something to keep an eye on for Wikispeech people

Change 289318 had a related patch set uploaded (by TheDJ):
Allow transform callers to add a classname

https://gerrit.wikimedia.org/r/289318

Change 289318 merged by jenkins-bot:
Allow transform callers to add a classname

https://gerrit.wikimedia.org/r/289318

  1. One option is to fix T60478: Improve interface for MediaHandlers to add JavaScript.
  2. Another would be to have a TimedMediaHandler::getPlayerModules()
  3. And lastly, we could have ext.score modules, that depend directly on TMH modules...

The best option would be to have something like TimedMediaHandler::getPlayerModules() in my view.

Ebe123 renamed this task from Formalize how TMH provides a player for Score generated ogg/vorbis files to Formalize how TMH provides a player for Score-generated ogg/vorbis files.Jul 4 2019, 3:43 PM